Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 511333002: Removing "using" declarations that import names in the C++ Standard library.(Source/platform/audio) (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
tkent, Raymond Toy
CC:
blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Removing "using" declarations that import names in the C++ Standard library.(Source/platform/audio) This is as per the the coding guidelines for blink. Do not use "using" declarations of any kind to import names in the standard template library. Directly qualify the names at the point they're used instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -72 lines) Patch
M Source/platform/DateComponents.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/SharedBuffer.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M Source/platform/ThreadTimers.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/Timer.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M Source/platform/audio/AudioDelayDSPKernel.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/audio/AudioResampler.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/audio/AudioResamplerKernel.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/audio/Distance.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/audio/DynamicsCompressorKernel.cpp View 8 chunks +8 lines, -10 lines 0 comments Download
M Source/platform/audio/EqualPowerPanner.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/platform/audio/HRTFDatabase.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/platform/audio/HRTFElevation.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/audio/HRTFKernel.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/audio/HRTFPanner.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/platform/audio/SincResampler.cpp View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
shreeramk
6 years, 3 months ago (2014-08-28 19:44:48 UTC) #1
Raymond Toy
rtoy@chromium.org changed reviewers: + rtoy@chromium.org
6 years, 3 months ago (2014-08-28 20:15:15 UTC) #2
Raymond Toy
Lgtm for webaudio files.
6 years, 3 months ago (2014-08-28 20:15:16 UTC) #3
shreeramk
shreeram.k@samsung.com changed reviewers: + tkent@chromium.org
6 years, 3 months ago (2014-08-28 20:31:47 UTC) #4
shreeramk
@tkent: Please review. Thanks!
6 years, 3 months ago (2014-08-28 20:32:28 UTC) #5
tkent
lgtm
6 years, 3 months ago (2014-08-30 17:50:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/511333002/1
6 years, 3 months ago (2014-08-30 17:51:35 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-08-30 18:52:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181135

Powered by Google App Engine
This is Rietveld 408576698