Add a use counter and deprecation message for showModalDialog

Add a use counter and deprecation message for showModalDialog

Mozilla is also interested in deprecating this API. This CL adds a use counter
to see how feasible that might be.

R=adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161186

[jamesr, 2013-10-30 22:29:49]

lgtm

[adamk, 2013-10-30 22:31:25]

https://codereview.chromium.org/51033005/diff/1/Source/core/page/UseCounter.cpp
File Source/core/page/UseCounter.cpp (right):

https://codereview.chromium.org/51033005/diff/1/Source/core/page/UseCounter.c...
Source/core/page/UseCounter.cpp:685: return "Blink is considering deprecating
showModalDialog. Please consider using window.open and postMessage instead.";
The use of "Blink" here is a little odd; maybe "Chromium" would be clearer? I
guess I'm wondering why you're equivocating (I think you should at least drop
the second use of "consider" in this message, instead saying "Please use ...";
even if we didn't remove showModalDialog, everyone would be better off not using
it).

[abarth-chromium, 2013-10-30 22:37:49]

On 2013/10/30 22:31:25, adamk wrote:
>
https://codereview.chromium.org/51033005/diff/1/Source/core/page/UseCounter.cpp
> File Source/core/page/UseCounter.cpp (right):
> 
>
https://codereview.chromium.org/51033005/diff/1/Source/core/page/UseCounter.c...
> Source/core/page/UseCounter.cpp:685: return "Blink is considering deprecating
> showModalDialog. Please consider using window.open and postMessage instead.";
> The use of "Blink" here is a little odd; maybe "Chromium" would be clearer? I
> guess I'm wondering why you're equivocating (I think you should at least drop
> the second use of "consider" in this message, instead saying "Please use ...";
> even if we didn't remove showModalDialog, everyone would be better off not
using
> it).

Done.

[adamk, 2013-10-30 22:39:05]

lgtm

[commit-bot: I haz the power, 2013-10-30 22:42:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/51033005/70001

[commit-bot: I haz the power, 2013-10-31 01:55:59]

Retried try job too often on mac_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...

[commit-bot: I haz the power, 2013-10-31 17:53:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/51033005/200001

[commit-bot: I haz the power, 2013-10-31 21:05:03]

Retried try job too often on mac_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...

[commit-bot: I haz the power, 2013-11-01 16:57:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/51033005/330001

[commit-bot: I haz the power, 2013-11-01 18:17:29]

Change committed as 161186