Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: Source/core/frame/DOMWindow.cpp

Issue 51033005: Add a use counter and deprecation message for showModalDialog (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add missing result Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DOMWindow.cpp
diff --git a/Source/core/frame/DOMWindow.cpp b/Source/core/frame/DOMWindow.cpp
index 0a0e0def9c8ef9c7d674ce05d013f0363fa0ca53..15a499eed8652e0d313279030c78d9f2f4ba5fc9 100644
--- a/Source/core/frame/DOMWindow.cpp
+++ b/Source/core/frame/DOMWindow.cpp
@@ -1838,6 +1838,8 @@ void DOMWindow::showModalDialog(const String& urlString, const String& dialogFea
if (!canShowModalDialogNow(m_frame) || !firstWindow->allowPopUp())
return;
+ UseCounter::countDeprecation(this, UseCounter::ShowModalDialog);
+
WindowFeatures windowFeatures(dialogFeaturesString, screenAvailableRect(m_frame->view()));
Frame* dialogFrame = createWindow(urlString, emptyAtom, windowFeatures,
activeWindow, firstFrame, m_frame, function, functionContext);
« no previous file with comments | « LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt ('k') | Source/core/page/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698