Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: Source/core/page/UseCounter.cpp

Issue 51033005: Add a use counter and deprecation message for showModalDialog (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add missing result Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/UseCounter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/UseCounter.cpp
diff --git a/Source/core/page/UseCounter.cpp b/Source/core/page/UseCounter.cpp
index e821e0f14abe231f6998f6651ae8b507fa1b0475..f6437f0459aefba27435a9291bc56b57536c7423 100644
--- a/Source/core/page/UseCounter.cpp
+++ b/Source/core/page/UseCounter.cpp
@@ -681,6 +681,9 @@ String UseCounter::deprecationMessage(Feature feature)
case ScrollLeftBodyNotQuirksMode:
return "body.scrollLeft is deprecated in strict mode. Please use 'documentElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode.";
+ case ShowModalDialog:
+ return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « Source/core/page/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698