Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: Source/core/page/UseCounter.cpp

Issue 51033005: Add a use counter and deprecation message for showModalDialog (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add missing result Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/UseCounter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 663 matching lines...) Expand 10 before | Expand all | Expand 10 after
674 674
675 case EventReturnValue: 675 case EventReturnValue:
676 return "event.returnValue is deprecated. Please use the standard event.p reventDefault() instead."; 676 return "event.returnValue is deprecated. Please use the standard event.p reventDefault() instead.";
677 677
678 case ScrollTopBodyNotQuirksMode: 678 case ScrollTopBodyNotQuirksMode:
679 return "body.scrollTop is deprecated in strict mode. Please use 'documen tElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mod e."; 679 return "body.scrollTop is deprecated in strict mode. Please use 'documen tElement.scrollTop' if in strict mode and 'body.scrollTop' only if in quirks mod e.";
680 680
681 case ScrollLeftBodyNotQuirksMode: 681 case ScrollLeftBodyNotQuirksMode:
682 return "body.scrollLeft is deprecated in strict mode. Please use 'docume ntElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode."; 682 return "body.scrollLeft is deprecated in strict mode. Please use 'docume ntElement.scrollLeft' if in strict mode and 'body.scrollLeft' only if in quirks mode.";
683 683
684 case ShowModalDialog:
685 return "Chromium is considering deprecating showModalDialog. Please use window.open and postMessage instead.";
686
684 // Features that aren't deprecated don't have a deprecation message. 687 // Features that aren't deprecated don't have a deprecation message.
685 default: 688 default:
686 return String(); 689 return String();
687 } 690 }
688 } 691 }
689 692
690 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 693 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
691 { 694 {
692 ASSERT(feature >= firstCSSProperty); 695 ASSERT(feature >= firstCSSProperty);
693 ASSERT(feature <= lastCSSProperty); 696 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
722 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 725 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
723 { 726 {
724 // FIXME: We may want to handle stylesheets that have multiple owners 727 // FIXME: We may want to handle stylesheets that have multiple owners
725 // http://crbug.com/242125 728 // http://crbug.com/242125
726 if (sheetContents && !sheetContents->isUserStyleSheet() && sheetContents->ha sSingleOwnerNode()) 729 if (sheetContents && !sheetContents->isUserStyleSheet() && sheetContents->ha sSingleOwnerNode())
727 return getFrom(sheetContents->singleOwnerDocument()); 730 return getFrom(sheetContents->singleOwnerDocument());
728 return 0; 731 return 0;
729 } 732 }
730 733
731 } // namespace WebCore 734 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/page/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698