Extensions-related fixups for scoped_refptr conversion operator removal.

Extensions-related fixups for scoped_refptr conversion operator removal.

BUG=110610
TBR=bauerb@chromium.org

Committed: https://crrev.com/605ef8d5ac2e1c5ad78fff63a7412796df010250
Cr-Commit-Position: refs/heads/master@{#292420}

[dcheng, 2014-08-28 09:33:01]

dcheng@chromium.org changed reviewers:
+ kalman@chromium.org

[dcheng, 2014-08-28 09:33:01]

These are manual fixups for cases that the automated tool decided to skip.

Some code I ended up just adding .get() (mainly in test code). However, there's
a lot of code that passes a refcounted object as a raw pointer, which is
immediately saved into a scoped_refptr. I've changed those sites to pass the
argument as a const scoped_refptr<T>& to help indicate that the callee will take
a reference to it.

I've also updated a few callsites to return const scoped_refptr<T>& where
appropriate--it avoids an unnecessary ref/unref, if the caller doesn't need to
make sure it lives past that line of code.

[not at google - send to devlin, 2014-08-28 15:36:50]

On 2014/08/28 09:33:01, dcheng (OOO) wrote:
> These are manual fixups for cases that the automated tool decided to skip.
> 
> Some code I ended up just adding .get() (mainly in test code). However,
there's
> a lot of code that passes a refcounted object as a raw pointer, which is
> immediately saved into a scoped_refptr. I've changed those sites to pass the
> argument as a const scoped_refptr<T>& to help indicate that the callee will
take
> a reference to it.

Nice. Thanks for fixing those up.

> 
> I've also updated a few callsites to return const scoped_refptr<T>& where
> appropriate--it avoids an unnecessary ref/unref, if the caller doesn't need to
> make sure it lives past that line of code.

lgtm.

[dcheng, 2014-08-28 16:15:25]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:15:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/510313002/1

[commit-bot: I haz the power, 2014-08-28 16:54:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-28 16:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:57:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2014-08-28 17:05:53]

dcheng@chromium.org changed reviewers:
+ bauerb@chromium.org

[dcheng, 2014-08-28 17:05:53]

TBR bauerb for chrome/browser/content_settings/* changes.

[dcheng, 2014-08-28 17:06:18]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:07:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/510313002/1

[commit-bot: I haz the power, 2014-08-28 18:29:50]

Committed patchset #1 (id:1) as ebfd5c3a58a46310bacaad029e098430a2ca7ef6

[commit-bot: I haz the power, 2014-09-10 03:00:48]

Patchset 1 (id:??) landed as
https://crrev.com/605ef8d5ac2e1c5ad78fff63a7412796df010250
Cr-Commit-Position: refs/heads/master@{#292420}