Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 510313002: Extensions-related fixups for scoped_refptr conversion operator removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data_unittest.cc
diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc
index 33aef85e49a4e2c4e7c415297b42e18c7cc3c2d5..7374d3415a77c9567407eaaddcc22cc3c769ebab 100644
--- a/extensions/common/permissions/permissions_data_unittest.cc
+++ b/extensions/common/permissions/permissions_data_unittest.cc
@@ -664,9 +664,9 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
LoadManifestStrict("script_and_capture", "tab_specific.json");
const PermissionsData* permissions_data = extension->permissions_data();
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0));
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1));
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(2));
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0).get());
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1).get());
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(2).get());
std::set<GURL> no_urls;
@@ -699,7 +699,7 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
permissions_data->ClearTabSpecificPermissions(0);
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0));
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0).get());
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
@@ -736,7 +736,7 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
permissions_data->ClearTabSpecificPermissions(0);
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0));
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(0).get());
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
EXPECT_TRUE(
@@ -744,7 +744,7 @@ TEST_F(ExtensionScriptAndCaptureVisibleTest, TabSpecific) {
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
permissions_data->ClearTabSpecificPermissions(1);
- EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1));
+ EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1).get());
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698