Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: chrome/browser/extensions/sandboxed_unpacker.cc

Issue 510313002: Extensions-related fixups for scoped_refptr conversion operator removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/sandboxed_unpacker.h" 5 #include "chrome/browser/extensions/sandboxed_unpacker.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 return IPC::ReadParam(&pickle, &iter, catalogs); 212 return IPC::ReadParam(&pickle, &iter, catalogs);
213 } 213 }
214 214
215 } // namespace 215 } // namespace
216 216
217 SandboxedUnpacker::SandboxedUnpacker( 217 SandboxedUnpacker::SandboxedUnpacker(
218 const base::FilePath& crx_path, 218 const base::FilePath& crx_path,
219 Manifest::Location location, 219 Manifest::Location location,
220 int creation_flags, 220 int creation_flags,
221 const base::FilePath& extensions_dir, 221 const base::FilePath& extensions_dir,
222 base::SequencedTaskRunner* unpacker_io_task_runner, 222 const scoped_refptr<base::SequencedTaskRunner>& unpacker_io_task_runner,
223 SandboxedUnpackerClient* client) 223 SandboxedUnpackerClient* client)
224 : crx_path_(crx_path), 224 : crx_path_(crx_path),
225 client_(client), 225 client_(client),
226 extensions_dir_(extensions_dir), 226 extensions_dir_(extensions_dir),
227 got_response_(false), 227 got_response_(false),
228 location_(location), 228 location_(location),
229 creation_flags_(creation_flags), 229 creation_flags_(creation_flags),
230 unpacker_io_task_runner_(unpacker_io_task_runner) { 230 unpacker_io_task_runner_(unpacker_io_task_runner) {
231 } 231 }
232 232
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 831
832 void SandboxedUnpacker::Cleanup() { 832 void SandboxedUnpacker::Cleanup() {
833 DCHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread()); 833 DCHECK(unpacker_io_task_runner_->RunsTasksOnCurrentThread());
834 if (!temp_dir_.Delete()) { 834 if (!temp_dir_.Delete()) {
835 LOG(WARNING) << "Can not delete temp directory at " 835 LOG(WARNING) << "Can not delete temp directory at "
836 << temp_dir_.path().value(); 836 << temp_dir_.path().value();
837 } 837 }
838 } 838 }
839 839
840 } // namespace extensions 840 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker.h ('k') | chrome/browser/extensions/test_extension_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698