Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: extensions/common/permissions/permissions_data.h

Issue 510313002: Extensions-related fixups for scoped_refptr conversion operator removal. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index dd74d28dfa74c35e2dc0ee51747642124cd429ae..ba2f3c3aa54078bbca0e1843e7fc2ec9942e3e70 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -200,13 +200,14 @@ class PermissionsData {
// page itself.
bool CanCaptureVisiblePage(int tab_id, std::string* error) const;
- scoped_refptr<const PermissionSet> active_permissions() const {
+ const scoped_refptr<const PermissionSet>& active_permissions() const {
+ // TODO(dcheng): What is the point of this lock?
base::AutoLock auto_lock(runtime_lock_);
return active_permissions_unsafe_;
}
- scoped_refptr<const PermissionSet> withheld_permissions() const {
- base::AutoLock auto_lock(runtime_lock_);
+ const scoped_refptr<const PermissionSet>& withheld_permissions() const {
+ // TODO(dcheng): What is the point of this lock?
return withheld_permissions_unsafe_;
}
« no previous file with comments | « extensions/common/extension_messages.cc ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698