Remove implicit conversions from scoped_refptr to T* in components/policy/

Remove implicit conversions from scoped_refptr to T* in components/policy/

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.

BUG=110610
Committed: https://crrev.com/28fa7ca627e09e89ba0290edc2ba2693c09497b7
Cr-Commit-Position: refs/heads/master@{#291928}

[dcheng, 2014-08-25 19:36:28]

dcheng@chromium.org changed reviewers:
+ bartfab@chromium.org

[dcheng, 2014-08-25 19:36:29]

+bartfab, please take a look at this patch. It's a change generated by a
ClangTool, so the diffs are machine-generated. Please pardon the brief message,
Rietveld currently has a bug where grues are eating the initial message
template.

[bartfab (slow), 2014-08-25 19:39:13]

LGTM with one nit.

https://codereview.chromium.org/506633004/diff/1/components/policy/core/commo...
File
components/policy/core/common/cloud/cloud_policy_client_registration_helper.h
(right):

https://codereview.chromium.org/506633004/diff/1/components/policy/core/commo...
components/policy/core/common/cloud/cloud_policy_client_registration_helper.h:110:
scoped_refptr<net::URLRequestContextGetter> context_;
Nit: #include "base/memory/ref_counted.h"

[dcheng, 2014-08-25 20:59:59]

https://codereview.chromium.org/506633004/diff/1/components/policy/core/commo...
File
components/policy/core/common/cloud/cloud_policy_client_registration_helper.h
(right):

https://codereview.chromium.org/506633004/diff/1/components/policy/core/commo...
components/policy/core/common/cloud/cloud_policy_client_registration_helper.h:110:
scoped_refptr<net::URLRequestContextGetter> context_;
On 2014/08/25 19:39:13, bartfab wrote:
> Nit: #include "base/memory/ref_counted.h"

Done.

[dcheng, 2014-08-25 21:07:00]

PTAL. There are some additional diffs in
cloud_policy_client_registration_helper.cc now, due to the fact that context_
changed from a T* to a scoped_refptr<T>.

[bartfab (slow), 2014-08-25 22:09:18]

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/device_management_service_unittest.cc
(right):

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/device_management_service_unittest.cc:81:
DeviceManagementRequestJob::TYPE_REGISTRATION, request_context_.get());
Why not make the DeviceManagementRequestJob take a scoped_refptr as well?

[dcheng, 2014-08-25 22:11:56]

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/device_management_service_unittest.cc
(right):

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/device_management_service_unittest.cc:81:
DeviceManagementRequestJob::TYPE_REGISTRATION, request_context_.get());
On 2014/08/25 22:09:18, bartfab wrote:
> Why not make the DeviceManagementRequestJob take a scoped_refptr as well?

This patch was generated by a tool. The tool tries to do the simplest possible
thing that it believes to be equivalent to the existing code (as long as it
thinks it's safe). If this is something you feel strongly about, I'd be happy to
address it in a followup patch--I'd prefer to minimize the number of manual
changes I have to make to machine-generated CLs.

[bartfab (slow), 2014-08-26 10:11:55]

lgtm

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
File components/policy/core/common/cloud/device_management_service_unittest.cc
(right):

https://codereview.chromium.org/506633004/diff/40001/components/policy/core/c...
components/policy/core/common/cloud/device_management_service_unittest.cc:81:
DeviceManagementRequestJob::TYPE_REGISTRATION, request_context_.get());
On 2014/08/25 22:11:56, dcheng (OOO) wrote:
> On 2014/08/25 22:09:18, bartfab wrote:
> > Why not make the DeviceManagementRequestJob take a scoped_refptr as well?
> 
> This patch was generated by a tool. The tool tries to do the simplest possible
> thing that it believes to be equivalent to the existing code (as long as it
> thinks it's safe). If this is something you feel strongly about, I'd be happy
to
> address it in a followup patch--I'd prefer to minimize the number of manual
> changes I have to make to machine-generated CLs.

Sorry, I misunderstood your patch as also trying to reduce the numbers of places
where we hold a raw pointer istead of a scoped_refptr. But I see that you are
only trying to remove implicit conversions and the occasional switch from raw
pointer to scoped_refptr is just a (positive) side effect of your work.

[dcheng, 2014-08-26 15:00:38]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 15:01:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506633004/40001

[commit-bot: I haz the power, 2014-08-26 17:31:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:31:27]

Failed to commit the patch.

[dcheng, 2014-08-26 17:41:37]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:42:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506633004/40001

[commit-bot: I haz the power, 2014-08-26 17:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:43:37]

Failed to commit the patch.

[dcheng, 2014-08-26 17:45:10]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:46:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506633004/40001

[commit-bot: I haz the power, 2014-08-26 17:47:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:47:37]

Failed to commit the patch.

[dcheng, 2014-08-26 17:48:36]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:50:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/506633004/40001

[commit-bot: I haz the power, 2014-08-26 17:51:31]

Committed patchset #3 (40001) as b3d2ce358e2413436505772727e4c3cc9d466be9

[commit-bot: I haz the power, 2014-09-10 02:43:38]

Patchset 3 (id:??) landed as
https://crrev.com/28fa7ca627e09e89ba0290edc2ba2693c09497b7
Cr-Commit-Position: refs/heads/master@{#291928}