components/policy/core/common/schema.cc - Issue 506633004: Remove implicit conversions from scoped_refptr to T* in components/policy/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/schema.cc

Issue 506633004: Remove implicit conversions from scoped_refptr to T* in components/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some more changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/cloud/device_management_service_unittest.cc ('K') | « components/policy/core/common/cloud/user_policy_request_context.cc ('k') | components/policy/core/common/schema_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/schema.cc

diff --git a/components/policy/core/common/schema.cc b/components/policy/core/common/schema.cc

index 7359938f3d9acc9e17754cbe3b111e0c3ed1f9f1..44931707d2266e24af91ce2e1b902a0d5ea31375 100644

--- a/components/policy/core/common/schema.cc

+++ b/components/policy/core/common/schema.cc

@@ -975,7 +975,7 @@ Schema Schema::Parse(const std::string& content, std::string* error) {

scoped_refptr<const InternalStorage> storage =

InternalStorage::ParseSchema(*dict, error);

- if (!storage)

+ if (!storage.get())

return Schema();

return Schema(storage, storage->root_node());

}