Remove implicit conversions from scoped_refptr to T* in components/policy/

components/policy/core/common/cloud/device_management_service_unittest.cc

Index: components/policy/core/common/cloud/device_management_service_unittest.cc
diff --git a/components/policy/core/common/cloud/device_management_service_unittest.cc b/components/policy/core/common/cloud/device_management_service_unittest.cc
index 1d9283474699df6d453e972d7e7beeebd014a318..28b740aa485925ff184c69126dc8aec6f8c6ba7a 100644
--- a/components/policy/core/common/cloud/device_management_service_unittest.cc
+++ b/components/policy/core/common/cloud/device_management_service_unittest.cc
@@ -77,9 +77,8 @@ class DeviceManagementServiceTestBase : public testing::Test {
   }
 
   DeviceManagementRequestJob* StartRegistrationJob() {
-    DeviceManagementRequestJob* job =
-        service_->CreateJob(DeviceManagementRequestJob::TYPE_REGISTRATION,
-                            request_context_);
+    DeviceManagementRequestJob* job = service_->CreateJob(
+        DeviceManagementRequestJob::TYPE_REGISTRATION, request_context_.get());

[bartfab (slow), 2014/08/25 22:09:18]

Why not make the DeviceManagementRequestJob take a scoped_refptr as well?

[dcheng, 2014/08/25 22:11:56]

This patch was generated by a tool. The tool tries to do the simplest possible
thing that it believes to be equivalent to the existing code (as long as it
thinks it's safe). If this is something you feel strongly about, I'd be happy to
address it in a followup patch--I'd prefer to minimize the number of manual
changes I have to make to machine-generated CLs.

[bartfab (slow), 2014/08/26 10:11:55]

Sorry, I misunderstood your patch as also trying to reduce the numbers of places
where we hold a raw pointer istead of a scoped_refptr. But I see that you are
only trying to remove implicit conversions and the occasional switch from raw
pointer to scoped_refptr is just a (positive) side effect of your work.

     job->SetGaiaToken(kGaiaAuthToken);
     job->SetOAuthToken(kOAuthToken);
     job->SetClientID(kClientID);
@@ -94,7 +93,7 @@ class DeviceManagementServiceTestBase : public testing::Test {
   DeviceManagementRequestJob* StartApiAuthCodeFetchJob() {
     DeviceManagementRequestJob* job = service_->CreateJob(
         DeviceManagementRequestJob::TYPE_API_AUTH_CODE_FETCH,
-        request_context_);
+        request_context_.get());
     job->SetGaiaToken(kGaiaAuthToken);
     job->SetOAuthToken(kOAuthToken);
     job->SetClientID(kClientID);
@@ -109,7 +108,7 @@ class DeviceManagementServiceTestBase : public testing::Test {
   DeviceManagementRequestJob* StartUnregistrationJob() {
     DeviceManagementRequestJob* job =
         service_->CreateJob(DeviceManagementRequestJob::TYPE_UNREGISTRATION,
-                            request_context_);
+                            request_context_.get());
     job->SetDMToken(kDMToken);
     job->SetClientID(kClientID);
     job->GetRequest()->mutable_unregister_request();
@@ -121,9 +120,8 @@ class DeviceManagementServiceTestBase : public testing::Test {
   }
 
   DeviceManagementRequestJob* StartPolicyFetchJob() {
-    DeviceManagementRequestJob* job =
-        service_->CreateJob(DeviceManagementRequestJob::TYPE_POLICY_FETCH,
-                            request_context_);
+    DeviceManagementRequestJob* job = service_->CreateJob(
+        DeviceManagementRequestJob::TYPE_POLICY_FETCH, request_context_.get());
     job->SetGaiaToken(kGaiaAuthToken);
     job->SetOAuthToken(kOAuthToken);
     job->SetClientID(kClientID);
@@ -140,7 +138,7 @@ class DeviceManagementServiceTestBase : public testing::Test {
   DeviceManagementRequestJob* StartAutoEnrollmentJob() {
     DeviceManagementRequestJob* job =
         service_->CreateJob(DeviceManagementRequestJob::TYPE_AUTO_ENROLLMENT,
-                            request_context_);
+                            request_context_.get());
     job->SetClientID(kClientID);
     em::DeviceAutoEnrollmentRequest* request =
         job->GetRequest()->mutable_auto_enrollment_request();