Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: components/policy/core/common/schema_map_unittest.cc

Issue 506633004: Remove implicit conversions from scoped_refptr to T* in components/policy/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/schema_map.h" 5 #include "components/policy/core/common/schema_map.h"
6 6
7 #include "base/memory/weak_ptr.h" 7 #include "base/memory/weak_ptr.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "components/policy/core/common/external_data_fetcher.h" 9 #include "components/policy/core/common/external_data_fetcher.h"
10 #include "components/policy/core/common/external_data_manager.h" 10 #include "components/policy/core/common/external_data_manager.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 EXPECT_FALSE(map->HasComponents()); 89 EXPECT_FALSE(map->HasComponents());
90 90
91 // An extension schema does. 91 // An extension schema does.
92 domain_map[POLICY_DOMAIN_EXTENSIONS] = component_map; 92 domain_map[POLICY_DOMAIN_EXTENSIONS] = component_map;
93 map = new SchemaMap(domain_map); 93 map = new SchemaMap(domain_map);
94 EXPECT_TRUE(map->HasComponents()); 94 EXPECT_TRUE(map->HasComponents());
95 } 95 }
96 96
97 TEST_F(SchemaMapTest, Lookups) { 97 TEST_F(SchemaMapTest, Lookups) {
98 scoped_refptr<SchemaMap> map = CreateTestMap(); 98 scoped_refptr<SchemaMap> map = CreateTestMap();
99 ASSERT_TRUE(map); 99 ASSERT_TRUE(map.get());
100 EXPECT_TRUE(map->HasComponents()); 100 EXPECT_TRUE(map->HasComponents());
101 101
102 EXPECT_FALSE(map->GetSchema( 102 EXPECT_FALSE(map->GetSchema(
103 PolicyNamespace(POLICY_DOMAIN_CHROME, ""))); 103 PolicyNamespace(POLICY_DOMAIN_CHROME, "")));
104 EXPECT_FALSE(map->GetSchema( 104 EXPECT_FALSE(map->GetSchema(
105 PolicyNamespace(POLICY_DOMAIN_CHROME, "extension-1"))); 105 PolicyNamespace(POLICY_DOMAIN_CHROME, "extension-1")));
106 EXPECT_FALSE(map->GetSchema( 106 EXPECT_FALSE(map->GetSchema(
107 PolicyNamespace(POLICY_DOMAIN_CHROME, "legacy-extension"))); 107 PolicyNamespace(POLICY_DOMAIN_CHROME, "legacy-extension")));
108 EXPECT_FALSE(map->GetSchema( 108 EXPECT_FALSE(map->GetSchema(
109 PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, ""))); 109 PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "")));
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 newer = new SchemaMap(map); 333 newer = new SchemaMap(map);
334 newer->GetChanges(older, &removed, &added); 334 newer->GetChanges(older, &removed, &added);
335 ASSERT_EQ(2u, removed.size()); 335 ASSERT_EQ(2u, removed.size());
336 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_CHROME, ""), removed[0]); 336 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_CHROME, ""), removed[0]);
337 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), removed[1]); 337 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "xyz"), removed[1]);
338 ASSERT_EQ(1u, added.size()); 338 ASSERT_EQ(1u, added.size());
339 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "abc"), added[0]); 339 EXPECT_EQ(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, "abc"), added[0]);
340 } 340 }
341 341
342 } // namespace policy 342 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698