Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
cbentzel+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam, mcasas+watch_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, timvolodine, wfh+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/54c3719d6bd03e7f2a644b8ce611e68a67bc341f Cr-Commit-Position: refs/heads/master@{#291986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -45 lines) Patch
M content/browser/battery_status/battery_status_manager_linux.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/quota/quota_reservation_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/security_exploit_browsertest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/startup_task_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/time_zone_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/transition_request_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/utility_process_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_blob_url_request_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + avi@chromium.org
6 years, 3 months ago (2014-08-26 17:15:02 UTC) #1
dcheng
(This isn't actually all of content, this is the remainder after sharding out most of ...
6 years, 3 months ago (2014-08-26 17:15:03 UTC) #2
Avi (use Gerrit)
stampity stamp LGTM
6 years, 3 months ago (2014-08-26 19:38:53 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 19:40:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/504273002/1
6 years, 3 months ago (2014-08-26 19:41:04 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 20:47:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 48200442b474e21e104ec1df7636705a80fac3aa
6 years, 3 months ago (2014-08-26 21:53:13 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:45:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54c3719d6bd03e7f2a644b8ce611e68a67bc341f
Cr-Commit-Position: refs/heads/master@{#291986}

Powered by Google App Engine
This is Rietveld 408576698