content/browser/tracing/tracing_controller_impl.cc - Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/tracing_controller_impl.cc

diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc

index 5fe4d2f0fd7ffbd1d354707c3581f06a1c556b4b..ca480c70638cf829cc292c7cb2a683d7bc5474cb 100644

--- a/content/browser/tracing/tracing_controller_impl.cc

+++ b/content/browser/tracing/tracing_controller_impl.cc

@@ -133,7 +133,7 @@ void TracingControllerImpl::ResultFile::CloseTask(

size_t written = fwrite(trailevents, strlen(trailevents), 1, file_);

DCHECK(written == 1);

- if (system_trace_) {

+ if (system_trace_.get()) {

#if defined(OS_WIN)

// The Windows kernel events are kept into a JSon format stored as string

// and must not be escaped.

« no previous file with comments | « content/browser/time_zone_monitor_linux.cc ('k') | content/browser/transition_request_manager.cc » ('j') | no next file with comments »