content/browser/security_exploit_browsertest.cc - Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/quota/quota_reservation_manager_unittest.cc ('k') | content/browser/speech/speech_recognition_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index 9fadec049a7824e44dfb0251c4a94b93eaf10ddb..3971285583aab32f83b253d6b9d0784a7c793786 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -139,8 +139,10 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest,

new SessionStorageNamespaceImpl(dom_storage_context));

// Cause a deliberate collision in routing ids.

int main_frame_routing_id = duplicate_routing_id + 1;

- pending_rvh->CreateNewWindow(

- duplicate_routing_id, main_frame_routing_id, params, session_storage);

+ pending_rvh->CreateNewWindow(duplicate_routing_id,

+ main_frame_routing_id,

+ params,

+ session_storage.get());

// If the above operation doesn't cause a crash, the test has succeeded!

}