content/browser/web_contents/web_contents_impl_unittest.cc - Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 504273002: Remove implicit conversions from scoped_refptr to T* in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/utility_process_host_impl.cc ('k') | content/browser/web_contents/web_contents_view_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index 3d37ab9b7762688db21a989bb4e79862cb0c07bc..e2ef0e578ae3c1c8ea288b508e7229fdf1343233 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -2591,12 +2591,12 @@ TEST_F(WebContentsImplTest, ActiveContentsCountBasic) {

EXPECT_EQ(0u, instance2->GetRelatedActiveContentsCount());

scoped_ptr<TestWebContents> contents1(

- TestWebContents::Create(browser_context(), instance1));

+ TestWebContents::Create(browser_context(), instance1.get()));

EXPECT_EQ(1u, instance1->GetRelatedActiveContentsCount());

EXPECT_EQ(1u, instance2->GetRelatedActiveContentsCount());

scoped_ptr<TestWebContents> contents2(

- TestWebContents::Create(browser_context(), instance1));

+ TestWebContents::Create(browser_context(), instance1.get()));

EXPECT_EQ(2u, instance1->GetRelatedActiveContentsCount());

EXPECT_EQ(2u, instance2->GetRelatedActiveContentsCount());

@@ -2618,7 +2618,7 @@ TEST_F(WebContentsImplTest, ActiveContentsCountNavigate) {

EXPECT_EQ(0u, instance->GetRelatedActiveContentsCount());

scoped_ptr<TestWebContents> contents(

- TestWebContents::Create(browser_context(), instance));

+ TestWebContents::Create(browser_context(), instance.get()));

EXPECT_EQ(1u, instance->GetRelatedActiveContentsCount());

// Navigate to a URL.

@@ -2656,7 +2656,7 @@ TEST_F(WebContentsImplTest, ActiveContentsCountChangeBrowsingInstance) {