Rename CustomElementCallbackDispatcher

Rename CustomElementCallbackDispatcher

Rename CustomElementCallbackDispatcher to CustomElementProcessingStack

TBR=esprehn@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181323

[deepak.sa, 2014-08-25 17:21:49]

This class has to be renamed, right?
As this required a lot of changes, so just wanted to confirm that this change is
acceptable. 
Thanks in advance!

P.S. This is not the full patch.

[deepak.sa, 2014-08-26 14:09:11]

Ping!

[dglazkov, 2014-08-26 15:03:37]

You still have the [WIP] in the patch title?

[deepak.sa, 2014-08-26 15:12:19]

On 2014/08/26 15:03:37, dglazkov wrote:
> You still have the [WIP] in the patch title?

Yes, it is an incomplete patch. It was uploaded to ensure that these changes are
needed.
I have asked dominicc about this, in the first comment.

[dominicc (has gone to gerrit), 2014-08-27 20:20:24]

Yes, this is a good rename. I think the direction of this patch is good.

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
File Source/core/dom/custom/CustomElementProcessingStack.cpp (right):

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
Source/core/dom/custom/CustomElementProcessingStack.cpp:63: // FIXME: without
this line, webkit-style script is generating error.
I would not add an unused variable just to appease the style checker. Run the
checker manually, then verify this is the only error, then use --bypass-hooks to
upload.

You could file a bug and point to your patch.

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
File Source/core/dom/custom/CustomElementProcessingStack.h (right):

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
Source/core/dom/custom/CustomElementProcessingStack.h:41: // FIXME: Rename this
CustomElementProcessingStack. It only handles
You should remove this, naturally.

[deepak.sa, 2014-08-28 07:02:42]

deepak.sa@samsung.com changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org

[deepak.sa, 2014-08-28 07:02:42]

PTAL?
Thanks!

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
File Source/core/dom/custom/CustomElementProcessingStack.cpp (right):

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
Source/core/dom/custom/CustomElementProcessingStack.cpp:63: // FIXME: without
this line, webkit-style script is generating error.
On 2014/08/27 20:20:23, dominicc--slow until 9.9 wrote:
> I would not add an unused variable just to appease the style checker. Run the
> checker manually, then verify this is the only error, then use --bypass-hooks
to
> upload.
> 
> You could file a bug and point to your patch.

I didn't knew how to by pass the style-check, so that's why i added this
variable. I knew it was a bad idea. Removed in the next patch.
I'll file a bug for this.

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
File Source/core/dom/custom/CustomElementProcessingStack.h (right):

https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/Custo...
Source/core/dom/custom/CustomElementProcessingStack.h:41: // FIXME: Rename this
CustomElementProcessingStack. It only handles
On 2014/08/27 20:20:23, dominicc--slow until 9.9 wrote:
> You should remove this, naturally.

Oops. Sorry!

[deepak.sa, 2014-09-03 07:28:37]

Ping!

[dominicc (has gone to gerrit), 2014-09-03 07:56:59]

LGTM modulo two nits inline.

https://codereview.chromium.org/503043003/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/custom/V8NodeCustom.cpp (right):

https://codereview.chromium.org/503043003/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/custom/V8NodeCustom.cpp:51: #include
"core/dom/custom/CustomElementProcessingStack.h"
Is this even needed here? Probably someone removed a method that used a
CallbackDeliveryScope and didn't clean this up.

https://codereview.chromium.org/503043003/diff/20001/Source/core/core.gypi
File Source/core/core.gypi (right):

https://codereview.chromium.org/503043003/diff/20001/Source/core/core.gypi#ne...
Source/core/core.gypi:2168: 'dom/custom/CustomElementProcessingStack.cpp',
Alphabetical order.

[haraken, 2014-09-03 07:57:31]

LGTM for bindings/.

[deepak.sa, 2014-09-03 10:39:22]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-09-03 10:39:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/503043003/40001

[deepak.sa, 2014-09-03 10:51:34]

web/ required.

[haraken, 2014-09-03 11:24:34]

On 2014/09/03 10:51:34, deepak.sa wrote:
> web/ required.

You can TBR some web/ owner for this kind of trivial change.

[commit-bot: I haz the power, 2014-09-03 11:55:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[commit-bot: I haz the power, 2014-09-03 11:59:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-03 11:59:05]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[deepak.sa, 2014-09-03 14:01:13]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-09-03 14:02:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/503043003/60001

[commit-bot: I haz the power, 2014-09-03 15:11:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[commit-bot: I haz the power, 2014-09-03 15:15:41]

Committed patchset #4 (id:60001) as 181323