Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 503043003: Rename CustomElementCallbackDispatcher (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 3 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename CustomElementCallbackDispatcher Rename CustomElementCallbackDispatcher to CustomElementProcessingStack TBR=esprehn@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181323

Patch Set 1 #

Total comments: 4

Patch Set 2 : Full patch #

Total comments: 2

Patch Set 3 : Nits #

Patch Set 4 : TBR added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -290 lines) Patch
M Source/bindings/core/v8/CustomElementConstructorBuilder.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8NodeCustom.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 21 chunks +40 lines, -40 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/dom/custom/CustomElementCallbackDispatcher.h View 1 chunk +0 lines, -109 lines 0 comments Download
D Source/core/dom/custom/CustomElementCallbackDispatcher.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskQueueBase.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/dom/custom/CustomElementProcessingStack.h View 1 4 chunks +7 lines, -9 lines 0 comments Download
A + Source/core/dom/custom/CustomElementProcessingStack.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M Source/web/WebElement.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (3 generated)
deepak.sa
This class has to be renamed, right? As this required a lot of changes, so ...
6 years, 4 months ago (2014-08-25 17:21:49 UTC) #1
deepak.sa
Ping!
6 years, 3 months ago (2014-08-26 14:09:11 UTC) #2
dglazkov
You still have the [WIP] in the patch title?
6 years, 3 months ago (2014-08-26 15:03:37 UTC) #3
deepak.sa
On 2014/08/26 15:03:37, dglazkov wrote: > You still have the [WIP] in the patch title? ...
6 years, 3 months ago (2014-08-26 15:12:19 UTC) #4
dominicc (has gone to gerrit)
Yes, this is a good rename. I think the direction of this patch is good. ...
6 years, 3 months ago (2014-08-27 20:20:24 UTC) #5
deepak.sa
deepak.sa@samsung.com changed reviewers: + esprehn@chromium.org, haraken@chromium.org
6 years, 3 months ago (2014-08-28 07:02:42 UTC) #6
deepak.sa
PTAL? Thanks! https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/CustomElementProcessingStack.cpp File Source/core/dom/custom/CustomElementProcessingStack.cpp (right): https://codereview.chromium.org/503043003/diff/1/Source/core/dom/custom/CustomElementProcessingStack.cpp#newcode63 Source/core/dom/custom/CustomElementProcessingStack.cpp:63: // FIXME: without this line, webkit-style script ...
6 years, 3 months ago (2014-08-28 07:02:42 UTC) #7
deepak.sa
Ping!
6 years, 3 months ago (2014-09-03 07:28:37 UTC) #8
dominicc (has gone to gerrit)
LGTM modulo two nits inline. https://codereview.chromium.org/503043003/diff/20001/Source/bindings/core/v8/custom/V8NodeCustom.cpp File Source/bindings/core/v8/custom/V8NodeCustom.cpp (right): https://codereview.chromium.org/503043003/diff/20001/Source/bindings/core/v8/custom/V8NodeCustom.cpp#newcode51 Source/bindings/core/v8/custom/V8NodeCustom.cpp:51: #include "core/dom/custom/CustomElementProcessingStack.h" Is this ...
6 years, 3 months ago (2014-09-03 07:56:59 UTC) #9
haraken
LGTM for bindings/.
6 years, 3 months ago (2014-09-03 07:57:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/503043003/40001
6 years, 3 months ago (2014-09-03 10:39:33 UTC) #12
deepak.sa
web/ required.
6 years, 3 months ago (2014-09-03 10:51:34 UTC) #13
haraken
On 2014/09/03 10:51:34, deepak.sa wrote: > web/ required. You can TBR some web/ owner for ...
6 years, 3 months ago (2014-09-03 11:24:34 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 3 months ago (2014-09-03 11:55:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14304)
6 years, 3 months ago (2014-09-03 11:59:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/503043003/60001
6 years, 3 months ago (2014-09-03 14:02:31 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 3 months ago (2014-09-03 15:11:19 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 15:15:41 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 181323

Powered by Google App Engine
This is Rietveld 408576698