Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: Source/core/dom/custom/CustomElementProcessingStack.h

Issue 503043003: Rename CustomElementCallbackDispatcher (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 10 matching lines...) Expand all
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef CustomElementCallbackDispatcher_h 31 #ifndef CustomElementProcessingStack_h
32 #define CustomElementCallbackDispatcher_h 32 #define CustomElementProcessingStack_h
33 33
34 #include "core/dom/custom/CustomElementCallbackQueue.h" 34 #include "core/dom/custom/CustomElementCallbackQueue.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class CustomElementScheduler; 39 class CustomElementScheduler;
40 40
41 // FIXME: Rename this CustomElementProcessingStack. It only handles 41 // FIXME: Rename this CustomElementProcessingStack. It only handles
dominicc (has gone to gerrit) 2014/08/27 20:20:23 You should remove this, naturally.
deepak.sa 2014/08/28 07:02:42 Oops. Sorry!
42 // the processing stack. 42 // the processing stack.
43 class CustomElementCallbackDispatcher { 43 class CustomElementProcessingStack {
44 WTF_MAKE_NONCOPYABLE(CustomElementCallbackDispatcher); 44 WTF_MAKE_NONCOPYABLE(CustomElementProcessingStack);
45 public: 45 public:
46 // This is stack allocated in many DOM callbacks. Make it cheap. 46 // This is stack allocated in many DOM callbacks. Make it cheap.
47 class CallbackDeliveryScope { 47 class CallbackDeliveryScope {
48 public: 48 public:
49 CallbackDeliveryScope() 49 CallbackDeliveryScope()
50 : m_savedElementQueueStart(s_elementQueueStart) 50 : m_savedElementQueueStart(s_elementQueueStart)
51 { 51 {
52 s_elementQueueStart = s_elementQueueEnd; 52 s_elementQueueStart = s_elementQueueEnd;
53 } 53 }
54 54
55 ~CallbackDeliveryScope() 55 ~CallbackDeliveryScope()
56 { 56 {
57 if (s_elementQueueStart != s_elementQueueEnd) 57 if (s_elementQueueStart != s_elementQueueEnd)
58 processElementQueueAndPop(); 58 processElementQueueAndPop();
59 s_elementQueueStart = m_savedElementQueueStart; 59 s_elementQueueStart = m_savedElementQueueStart;
60 } 60 }
61 61
62 private: 62 private:
63 size_t m_savedElementQueueStart; 63 size_t m_savedElementQueueStart;
64 }; 64 };
65 65
66 static bool inCallbackDeliveryScope() { return s_elementQueueStart; } 66 static bool inCallbackDeliveryScope() { return s_elementQueueStart; }
67 67
68 protected: 68 protected:
69 friend class CustomElementScheduler; 69 friend class CustomElementScheduler;
70 static CustomElementCallbackDispatcher& instance(); 70 static CustomElementProcessingStack& instance();
71 void enqueue(CustomElementCallbackQueue*); 71 void enqueue(CustomElementCallbackQueue*);
72 72
73 private: 73 private:
74 CustomElementCallbackDispatcher() 74 CustomElementProcessingStack()
75 { 75 {
76 // Add a null element as a sentinel. This makes it possible to 76 // Add a null element as a sentinel. This makes it possible to
77 // identify elements queued when there is no 77 // identify elements queued when there is no
78 // CallbackDeliveryScope active. Also, if the processing stack 78 // CallbackDeliveryScope active. Also, if the processing stack
79 // is popped when empty, this sentinel will cause a null deref 79 // is popped when empty, this sentinel will cause a null deref
80 // crash. 80 // crash.
81 CustomElementCallbackQueue* sentinel = 0; 81 CustomElementCallbackQueue* sentinel = 0;
82 for (size_t i = 0; i < kNumSentinels; i++) 82 for (size_t i = 0; i < kNumSentinels; i++)
83 m_flattenedProcessingStack.append(sentinel); 83 m_flattenedProcessingStack.append(sentinel);
84 ASSERT(s_elementQueueEnd == m_flattenedProcessingStack.size()); 84 ASSERT(s_elementQueueEnd == m_flattenedProcessingStack.size());
(...skipping 14 matching lines...) Expand all
99 99
100 // The processing stack, flattened. Element queues lower in the 100 // The processing stack, flattened. Element queues lower in the
101 // stack appear toward the head of the vector. The first element 101 // stack appear toward the head of the vector. The first element
102 // is a null sentinel value. 102 // is a null sentinel value.
103 static const size_t kNumSentinels = 1; 103 static const size_t kNumSentinels = 1;
104 Vector<CustomElementCallbackQueue*> m_flattenedProcessingStack; 104 Vector<CustomElementCallbackQueue*> m_flattenedProcessingStack;
105 }; 105 };
106 106
107 } 107 }
108 108
109 #endif // CustomElementCallbackDispatcher_h 109 #endif // CustomElementProcessingStack_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698