Rename CustomElementCallbackDispatcher

Source/core/dom/custom/CustomElementProcessingStack.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
-#include "core/dom/custom/CustomElementCallbackDispatcher.h"
+#include "core/dom/custom/CustomElementProcessingStack.h"
 
 #include "core/dom/custom/CustomElementCallbackQueue.h"
 #include "core/dom/custom/CustomElementScheduler.h"
 #include "wtf/MainThread.h"
 
 namespace blink {
 
-size_t CustomElementCallbackDispatcher::s_elementQueueStart = 0;
+size_t CustomElementProcessingStack::s_elementQueueStart = 0;
 
 // The base of the stack has a null sentinel value.
-size_t CustomElementCallbackDispatcher::s_elementQueueEnd = kNumSentinels;
+size_t CustomElementProcessingStack::s_elementQueueEnd = kNumSentinels;
 
-CustomElementCallbackDispatcher& CustomElementCallbackDispatcher::instance()
+CustomElementProcessingStack& CustomElementProcessingStack::instance()
 {
-    DEFINE_STATIC_LOCAL(CustomElementCallbackDispatcher, instance, ());
+    DEFINE_STATIC_LOCAL(CustomElementProcessingStack, instance, ());
     return instance;
 }
 
 // Dispatches callbacks when popping the processing stack.
-void CustomElementCallbackDispatcher::processElementQueueAndPop()
+void CustomElementProcessingStack::processElementQueueAndPop()
 {
     instance().processElementQueueAndPop(s_elementQueueStart, s_elementQueueEnd);
 }
 
-void CustomElementCallbackDispatcher::processElementQueueAndPop(size_t start, size_t end)
+void CustomElementProcessingStack::processElementQueueAndPop(size_t start, size_t end)
 {
     ASSERT(isMainThread());
     CustomElementCallbackQueue::ElementQueueId thisQueue = currentElementQueue();
 
-    for (size_t i = start; i < end; i++) {
+    for (size_t i = start; i < end; ++i) {
+        // FIXME: without this line, webkit-style script is generating error.

[dominicc (has gone to gerrit), 2014/08/27 20:20:23]

I would not add an unused variable just to appease the style checker. Run the
checker manually, then verify this is the only error, then use --bypass-hooks to
upload.

You could file a bug and point to your patch.

[deepak.sa, 2014/08/28 07:02:42]

I didn't knew how to by pass the style-check, so that's why i added this
variable. I knew it was a bad idea. Removed in the next patch.
I'll file a bug for this.

+        // Remove this variable.
+        bool wrongVariable = false;
         {
             // The created callback may schedule entered document
             // callbacks.
             CallbackDeliveryScope deliveryScope;
             m_flattenedProcessingStack[i]->processInElementQueue(thisQueue);
         }
 
         ASSERT(start == s_elementQueueStart);
         ASSERT(end == s_elementQueueEnd);
     }
 
     // Pop the element queue from the processing stack
     m_flattenedProcessingStack.resize(start);
     s_elementQueueEnd = start;
 
     if (s_elementQueueStart == kNumSentinels)
         CustomElementScheduler::callbackDispatcherDidFinish();
 }
 
-void CustomElementCallbackDispatcher::enqueue(CustomElementCallbackQueue* callbackQueue)
+void CustomElementProcessingStack::enqueue(CustomElementCallbackQueue* callbackQueue)
 {
     ASSERT(inCallbackDeliveryScope());
 
     if (callbackQueue->owner() == currentElementQueue())
         return;
 
     callbackQueue->setOwner(currentElementQueue());
 
     m_flattenedProcessingStack.append(callbackQueue);
     ++s_elementQueueEnd;
 }
 
 } // namespace blink