Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 502033003: Move ExtensionActionStorageManager out of extension_action_api.* (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ExtensionActionStorageManager out of extension_action_api.* There's really no reason to have these in the same file, and it's cluttering it up. Bonus: - Convert ExtensionActionStorageManager to use a BrowserContext. - Remove ExtensionActionStorageManager's ExtensionService dependency. - Remove ExtensionActionStorageManager's public weak ptr interface - Consolidate extension_misc:: ExtensionAction icon stuff and ExtensionActionAPI icon stuff. BUG=407290 Committed: https://crrev.com/2813c1b0f610548451d05287d81a342cb46754c1 Cr-Commit-Position: refs/heads/master@{#292036}

Patch Set 1 : #

Patch Set 2 : Latest master for CQ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -338 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 4 chunks +1 line, -45 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 6 chunks +6 lines, -276 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_action_manager.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A chrome/browser/extensions/extension_action_storage_manager.h View 1 chunk +68 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_action_storage_manager.cc View 1 chunk +279 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/common/constants.h View 1 2 chunks +14 lines, -3 lines 0 comments Download
M extensions/common/constants.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Devlin
Yoyo, please take a look when you can. :)
6 years, 4 months ago (2014-08-25 20:49:57 UTC) #1
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-08-26 19:19:18 UTC) #2
Devlin
Patchset #2 (id:40001) has been deleted
6 years, 3 months ago (2014-08-26 21:08:16 UTC) #3
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 3 months ago (2014-08-26 21:20:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/502033003/60001
6 years, 3 months ago (2014-08-26 21:22:12 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 22:55:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (60001) as 7155dd4af17411c8a37461bca2b181f70a97d435
6 years, 3 months ago (2014-08-26 23:51:26 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:47:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2813c1b0f610548451d05287d81a342cb46754c1
Cr-Commit-Position: refs/heads/master@{#292036}

Powered by Google App Engine
This is Rietveld 408576698