Move ExtensionActionStorageManager out of extension_action_api.*

chrome/browser/extensions/api/extension_action/extension_action_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 
 #include <string>
 
-#include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
-#include "base/scoped_observer.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/browser/browser_context_keyed_api_factory.h"
-#include "extensions/browser/extension_registry_observer.h"
+#include "third_party/skia/include/core/SkColor.h"
 
 namespace base {
 class DictionaryValue;
 }
 
 namespace content {
 class BrowserContext;
 class WebContents;
 }
 
 namespace extensions {
 class ExtensionPrefs;
-class ExtensionRegistry;
-class TabHelper;
 
 class ExtensionActionAPI : public BrowserContextKeyedAPI {
  public:
   class Observer {
    public:
     // Called when there is a change to the given |extension_action|.
     // |web_contents| is the web contents that was affected, and
     // |browser_context| is the associated BrowserContext. (The latter is
     // included because ExtensionActionAPI is shared between normal and
     // incognito contexts, so |browser_context| may not equal
@@ skipping 76 matching lines @@
   static const char* service_name() { return "ExtensionActionAPI"; }
   static const bool kServiceRedirectedInIncognito = true;
 
   ObserverList<Observer> observers_;
 
   content::BrowserContext* browser_context_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionActionAPI);
 };
 
-// This class manages reading and writing browser action values from storage.
-class ExtensionActionStorageManager
-    : public ExtensionActionAPI::Observer,
-      public ExtensionRegistryObserver,
-      public base::SupportsWeakPtr<ExtensionActionStorageManager> {
- public:
-  explicit ExtensionActionStorageManager(Profile* profile);
-  virtual ~ExtensionActionStorageManager();
-
- private:
-  // ExtensionActionAPI::Observer:
-  virtual void OnExtensionActionUpdated(
-      ExtensionAction* extension_action,
-      content::WebContents* web_contents,
-      content::BrowserContext* browser_context) OVERRIDE;
-  virtual void OnExtensionActionAPIShuttingDown() OVERRIDE;
-
-  // ExtensionRegistryObserver:
-  virtual void OnExtensionLoaded(content::BrowserContext* browser_context,
-                                 const Extension* extension) OVERRIDE;
-
-  // Reads/Writes the ExtensionAction's default values to/from storage.
-  void WriteToStorage(ExtensionAction* extension_action);
-  void ReadFromStorage(
-      const std::string& extension_id, scoped_ptr<base::Value> value);
-
-  Profile* profile_;
-
-  ScopedObserver<ExtensionActionAPI, ExtensionActionAPI::Observer>
-      extension_action_observer_;
-
-  // Listen to extension loaded notification.
-  ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
-      extension_registry_observer_;
-};
-
 // Implementation of the browserAction and pageAction APIs.
 //
 // Divergent behaviour between the two is minimal (pageAction has required
 // tabIds while browserAction's are optional, they have different internal
 // browser notification requirements, and not all functions are defined for all
 // APIs).
 class ExtensionActionFunction : public ChromeSyncExtensionFunction {
  public:
   static bool ParseCSSColorString(const std::string& color_string,
                                   SkColor* result);
 
  protected:
   ExtensionActionFunction();
   virtual ~ExtensionActionFunction();
   virtual bool RunSync() OVERRIDE;
   virtual bool RunExtensionAction() = 0;
 
   bool ExtractDataFromArguments();
   void NotifyChange();
   bool SetVisible(bool visible);
 
-  // Extension-related information for |tab_id_|.
-  // CHECK-fails if there is no tab.
-  extensions::TabHelper& tab_helper() const;
-
   // All the extension action APIs take a single argument called details that
   // is a dictionary.
   base::DictionaryValue* details_;
 
   // The tab id the extension action function should apply to, if any, or
   // kDefaultTabId if none was specified.
   int tab_id_;
 
   // WebContents for |tab_id_| if one exists.
   content::WebContents* contents_;
@@ skipping 273 matching lines @@
 class PageActionGetPopupFunction
     : public extensions::ExtensionActionGetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.getPopup", PAGEACTION_GETPOPUP)
 
  protected:
   virtual ~PageActionGetPopupFunction() {}
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_