Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: extensions/common/constants.h

Issue 502033003: Move ExtensionActionStorageManager out of extension_action_api.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master for CQ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | extensions/common/constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/constants.h
diff --git a/extensions/common/constants.h b/extensions/common/constants.h
index 3dde500ab35891661f2d81228d3750a225c3efa5..3e9f17b9ef4811ae5ba5c1ececcde4a13f0c25f6 100644
--- a/extensions/common/constants.h
+++ b/extensions/common/constants.h
@@ -7,6 +7,7 @@
#include "base/basictypes.h"
#include "base/files/file_path.h"
+#include "ui/base/layout.h"
namespace extensions {
@@ -128,9 +129,19 @@ enum ExtensionIcons {
extern const int kExtensionIconSizes[];
extern const size_t kNumExtensionIconSizes;
-// List of sizes for extension icons that can be defined in the manifest.
-extern const int kExtensionActionIconSizes[];
-extern const size_t kNumExtensionActionIconSizes;
+struct IconRepresentationInfo {
+ // Size in pixels.
+ const int size;
+ // Size as a string that will be used to retrieve representation value from
+ // ExtensionAction SetIcon function arguments.
+ const char* const size_string;
+ // Scale factor for which the representation should be used.
+ const ui::ScaleFactor scale;
+};
+
+// The icon representations for extension actions.
+extern const IconRepresentationInfo kExtensionActionIconSizes[];
+const size_t kNumExtensionActionIconSizes = 2u;
} // namespace extension_misc
« no previous file with comments | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | extensions/common/constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698