chrome/browser/extensions/extension_action.cc - Issue 502033003: Move ExtensionActionStorageManager out of extension_action_api.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 502033003: Move ExtensionActionStorageManager out of extension_action_api.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master for CQ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action.cc

diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc

index 78934f4c59e6877d0ecce22cf8a683a5b718ccab..ff4b5e03d9287b606d13d6d376be6fe7246fbb74 100644

--- a/chrome/browser/extensions/extension_action.cc

+++ b/chrome/browser/extensions/extension_action.cc

@@ -58,7 +58,8 @@ bool HasValue(const std::map<int, T>& map, int tab_id) {

} // namespace

const int ExtensionAction::kDefaultTabId = -1;

-const int ExtensionAction::kPageActionIconMaxSize = 19;

+const int ExtensionAction::kPageActionIconMaxSize =

+ extension_misc::EXTENSION_ICON_ACTION;

ExtensionAction::ExtensionAction(const std::string& extension_id,

extensions::ActionInfo::Type action_type,