chrome/browser/extensions/api/management/management_api.cc - Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just in case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/image_writer_private/removable_storage_provider.cc ('k') | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index 7fe4b64e3383a7522e170e9e2c5654ccf2e4d489..413f13a8d22ddd516c633480cc4a8b95c6c95456 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -686,7 +686,7 @@ ManagementUninstallFunction::~ManagementUninstallFunction() {

bool ManagementUninstallFunction::RunAsync() {

scoped_ptr<management::Uninstall::Params> params(

management::Uninstall::Params::Create(*args_));

- EXTENSION_FUNCTION_VALIDATE(extension_);

+ EXTENSION_FUNCTION_VALIDATE(extension_.get());

EXTENSION_FUNCTION_VALIDATE(params.get());

bool show_confirm_dialog = true;