Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just in case Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/management/management_api.h" 5 #include "chrome/browser/extensions/api/management/management_api.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 679
680 ManagementUninstallFunction::ManagementUninstallFunction() { 680 ManagementUninstallFunction::ManagementUninstallFunction() {
681 } 681 }
682 682
683 ManagementUninstallFunction::~ManagementUninstallFunction() { 683 ManagementUninstallFunction::~ManagementUninstallFunction() {
684 } 684 }
685 685
686 bool ManagementUninstallFunction::RunAsync() { 686 bool ManagementUninstallFunction::RunAsync() {
687 scoped_ptr<management::Uninstall::Params> params( 687 scoped_ptr<management::Uninstall::Params> params(
688 management::Uninstall::Params::Create(*args_)); 688 management::Uninstall::Params::Create(*args_));
689 EXTENSION_FUNCTION_VALIDATE(extension_); 689 EXTENSION_FUNCTION_VALIDATE(extension_.get());
690 EXTENSION_FUNCTION_VALIDATE(params.get()); 690 EXTENSION_FUNCTION_VALIDATE(params.get());
691 691
692 bool show_confirm_dialog = true; 692 bool show_confirm_dialog = true;
693 // By default confirmation dialog isn't shown when uninstalling self, but this 693 // By default confirmation dialog isn't shown when uninstalling self, but this
694 // can be overridden with showConfirmDialog. 694 // can be overridden with showConfirmDialog.
695 if (params->id == extension_->id()) { 695 if (params->id == extension_->id()) {
696 show_confirm_dialog = params->options.get() && 696 show_confirm_dialog = params->options.get() &&
697 params->options->show_confirm_dialog.get() && 697 params->options->show_confirm_dialog.get() &&
698 *params->options->show_confirm_dialog; 698 *params->options->show_confirm_dialog;
699 } 699 }
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
1006 ManagementAPI::GetFactoryInstance() { 1006 ManagementAPI::GetFactoryInstance() {
1007 return g_factory.Pointer(); 1007 return g_factory.Pointer();
1008 } 1008 }
1009 1009
1010 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) { 1010 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
1011 management_event_router_.reset(new ManagementEventRouter(browser_context_)); 1011 management_event_router_.reset(new ManagementEventRouter(browser_context_));
1012 EventRouter::Get(browser_context_)->UnregisterObserver(this); 1012 EventRouter::Get(browser_context_)->UnregisterObserver(this);
1013 } 1013 }
1014 1014
1015 } // namespace extensions 1015 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698