chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 501263002: Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just in case Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/content_settings/content_settings_api.cc ('K') | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/api/mdns/dns_sd_registry.cc » ('j') | chrome/browser/extensions/api/permissions/permissions_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index 7f36d233950d20282c7d9844e6468704ab7fc5ba..d42b3ae7f078d3e3a1d7d3236fabcd2f432b7e04 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -115,7 +115,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest,

// Uninstall, then cancel via the confirm dialog.

scoped_refptr<ManagementUninstallFunction> uninstall_function(

new ManagementUninstallFunction());

- uninstall_function->set_extension(empty_extension);

+ uninstall_function->set_extension(empty_extension.get());

uninstall_function->set_user_gesture(true);

ManagementUninstallFunction::SetAutoConfirmForTest(false);

@@ -132,7 +132,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest,

// Uninstall, then accept via the confirm dialog.

uninstall_function = new ManagementUninstallFunction();

- uninstall_function->set_extension(empty_extension);

+ uninstall_function->set_extension(empty_extension.get());

ManagementUninstallFunction::SetAutoConfirmForTest(true);

uninstall_function->set_user_gesture(true);

util::RunFunctionAndReturnSingleResult(