Remove implicit conversions from scoped_refptr to T* in chrome/browser/extensions/api/

chrome/browser/extensions/api/content_settings/content_settings_api.cc

Index: chrome/browser/extensions/api/content_settings/content_settings_api.cc
diff --git a/chrome/browser/extensions/api/content_settings/content_settings_api.cc b/chrome/browser/extensions/api/content_settings/content_settings_api.cc
index 99f7fc0be134af984eb1423388679a2ea7a3ce2d..ad5904520f250d96cb35f3db887186a932ddd7d0 100644
--- a/chrome/browser/extensions/api/content_settings/content_settings_api.cc
+++ b/chrome/browser/extensions/api/content_settings/content_settings_api.cc
@@ -87,7 +87,7 @@ bool ContentSettingsContentSettingClearFunction::RunSync() {
     }
   }
 
-  ContentSettingsStore* store =
+  scoped_refptr<ContentSettingsStore> store =

[dcheng, 2014/08/26 00:50:20]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
content_settings_store() to return a const scoped_refptr<>& instead--this will
help avoid spurious refcount churn for callers that really don't need to retain
a reference. (I can also make this change, but please let me know if I should or
not.)

[Jeffrey Yasskin, 2014/08/26 01:14:16]

The change that introduced the scoped_refptr return changed several other places
to store the result into a scoped_refptr, so I'd guess .get() isn't safe.
Returning by & might work, but +rockot to be sure.

       ContentSettingsService::Get(GetProfile())->content_settings_store();
   store->ClearContentSettingsForExtension(extension_id(), scope);
 
@@ -238,7 +238,7 @@ bool ContentSettingsContentSettingSetFunction::RunSync() {
     return false;
   }
 
-  ContentSettingsStore* store =
+  scoped_refptr<ContentSettingsStore> store =

[dcheng, 2014/08/26 00:50:20]

Note: this variable type was rewritten instead of simply adding .get(), because
generally speaking, there is no way of determining if this is safe or not.

If this is safe, please let me know, and I will change this to call .get()
instead of rewriting the variable type. Also consider changing
content_settings_store() to return a const scoped_refptr<>& instead--this will
help avoid spurious refcount churn for callers that really don't need to retain
a reference. (I can also make this change, but please let me know if I should or
not.)

       ContentSettingsService::Get(GetProfile())->content_settings_store();
   store->SetExtensionContentSetting(extension_id(), primary_pattern,
                                     secondary_pattern, content_type,