Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 497013002: Revert 291221 "Athena: Adding basic resource management framewor..." (Closed)

Created:
6 years, 4 months ago by Finnur
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 291221 "Athena: Adding basic resource management framewor..." Reason: Failure on ASAN build bots. https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(3)/builds/2854/steps/athena_unittests/logs/OneAppActivity > Athena: Adding basic resource management framework (un-/re-loading) of V2 applications > > Functionality: > > The |AppRegistry| has for each running application an |AppActivityRegistry|. > > The |AppActivityRegistry| knows all activities associated with the application it represents. > It can furthermore shut the app entirely down upon resource manager request. It will then create > an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This > placeholder can then ask the |AppActivityRegistry| to restart the application again. > > A shutdown request for the application is only performed when all activities were marked for > UNLOAD. > > If there were multiple activities upon shutdown for one app, the app has to take care of > re-creating all windows and thus re-creating all activities. Since an activity match cannot > be performed, the |AppActivityProxy| will only be shown once and it will show in the location > of the most recently used activity of that app. If we later on find an app which really uses > multiple windows and it is imperative to keep the history for all of them tact & the app is > recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and > try to address it in a cleaner way, but at this time that seems rather un-useful since it is > not known if required. > > BUG=388085 > TEST=AppActivityTest.* > > Review URL: https://codereview.chromium.org/477523002 TBR=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1287 lines) Patch
M trunk/src/athena/activity/public/activity.h View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/athena/athena.gyp View 4 chunks +6 lines, -26 lines 0 comments Download
D trunk/src/athena/content/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/athena/content/app_activity.h View 5 chunks +3 lines, -18 lines 0 comments Download
M trunk/src/athena/content/app_activity.cc View 5 chunks +14 lines, -51 lines 0 comments Download
D trunk/src/athena/content/app_activity_proxy.h View 1 chunk +0 lines, -63 lines 0 comments Download
D trunk/src/athena/content/app_activity_proxy.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D trunk/src/athena/content/app_activity_registry.h View 1 chunk +0 lines, -103 lines 0 comments Download
D trunk/src/athena/content/app_activity_registry.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D trunk/src/athena/content/app_activity_unittest.cc View 1 chunk +0 lines, -412 lines 0 comments Download
D trunk/src/athena/content/app_registry_impl.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D trunk/src/athena/content/delegate/app_content_control_delegate_impl.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D trunk/src/athena/content/public/app_content_control_delegate.h View 1 chunk +0 lines, -40 lines 0 comments Download
D trunk/src/athena/content/public/app_registry.h View 1 chunk +0 lines, -72 lines 0 comments Download
M trunk/src/athena/content/web_activity.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/athena/content/web_activity.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/athena/main/athena_launcher.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/athena/main/athena_main.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/athena/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/athena/test/sample_activity.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/athena/test/sample_activity.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D trunk/src/athena/test/test_app_content_control_delegate_impl.cc View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
6 years, 4 months ago (2014-08-22 10:20:24 UTC) #1
Finnur
6 years, 4 months ago (2014-08-22 10:21:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r291370.

Powered by Google App Engine
This is Rietveld 408576698