Chromium Code Reviews Chromium Code Reviews
Issue
477523002:
Athena: Adding basic resource management framework (un-/re-loading) of V2 applications (Closed)
DescriptionAthena: Adding basic resource management framework (un-/re-loading) of V2 applications
Functionality:
The |AppRegistry| has for each running application an |AppActivityRegistry|.
The |AppActivityRegistry| knows all activities associated with the application it represents.
It can furthermore shut the app entirely down upon resource manager request. It will then create
an |AppActivityProxy| for the overview mode which shows a placeholder for an unloaded app. This
placeholder can then ask the |AppActivityRegistry| to restart the application again.
A shutdown request for the application is only performed when all activities were marked for
UNLOAD.
If there were multiple activities upon shutdown for one app, the app has to take care of
re-creating all windows and thus re-creating all activities. Since an activity match cannot
be performed, the |AppActivityProxy| will only be shown once and it will show in the location
of the most recently used activity of that app. If we later on find an app which really uses
multiple windows and it is imperative to keep the history for all of them tact & the app is
recreating them properly, (a lot of if's) we can revisit the single |AppActivityProxy| and
try to address it in a cleaner way, but at this time that seems rather un-useful since it is
not known if required.
BUG=388085
TEST=AppActivityTest.*
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291221
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291454
Patch Set 1 #Patch Set 2 : nit #Patch Set 3 : . #Patch Set 4 : Adding OWNERS #Patch Set 5 : Adding first unit test, more to come #Patch Set 6 : Added more tests, some are still missing #Patch Set 7 : . #
Total comments: 21
Patch Set 8 : Addressed, added all unit tests, see comments #Patch Set 9 : Forgot two files #
Total comments: 12
Patch Set 10 : Merged with trunk #
Total comments: 22
Patch Set 11 : Addressed #
Total comments: 30
Patch Set 12 : Addressed #
Total comments: 3
Patch Set 13 : Addressed nits #Patch Set 14 : Adding header for swarming build break #Patch Set 15 : Aaaaand another merge was required. #Patch Set 16 : fixed memory leak #Patch Set 17 : Aaaand another rebase. #
Messages
Total messages: 48 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
