Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: trunk/src/athena/content/app_activity.h

Issue 497013002: Revert 291221 "Athena: Adding basic resource management framewor..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/athena/content/OWNERS ('k') | trunk/src/athena/content/app_activity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/athena/content/app_activity.h
===================================================================
--- trunk/src/athena/content/app_activity.h (revision 291366)
+++ trunk/src/athena/content/app_activity.h (working copy)
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ATHENA_CONTENT_APP_ACTIVITY_H_
-#define ATHENA_CONTENT_APP_ACTIVITY_H_
+#ifndef ATHENA_CONTENT_PUBLIC_APP_ACTIVITY_H_
+#define ATHENA_CONTENT_PUBLIC_APP_ACTIVITY_H_
#include "athena/activity/public/activity.h"
#include "athena/activity/public/activity_view_model.h"
@@ -20,9 +20,6 @@
namespace athena {
-class AppActivityRegistry;
-
-// The activity object for a hosted V2 application.
class AppActivity : public Activity,
public ActivityViewModel,
public content::WebContentsObserver {
@@ -30,13 +27,13 @@
explicit AppActivity(extensions::ShellAppWindow* app_window);
virtual ~AppActivity();
+ protected:
// Activity:
virtual athena::ActivityViewModel* GetActivityViewModel() OVERRIDE;
virtual void SetCurrentState(Activity::ActivityState state) OVERRIDE;
virtual ActivityState GetCurrentState() OVERRIDE;
virtual bool IsVisible() OVERRIDE;
virtual ActivityMediaState GetMediaState() OVERRIDE;
- virtual aura::Window* GetWindow() OVERRIDE;
// ActivityViewModel:
virtual void Init() OVERRIDE;
@@ -47,20 +44,13 @@
virtual void CreateOverviewModeImage() OVERRIDE;
virtual gfx::ImageSkia GetOverviewModeImage() OVERRIDE;
- protected:
// content::WebContentsObserver:
virtual void TitleWasSet(content::NavigationEntry* entry,
bool explicit_set) OVERRIDE;
virtual void DidUpdateFaviconURL(
const std::vector<content::FaviconURL>& candidates) OVERRIDE;
- virtual void DidStartNavigationToPendingEntry(
- const GURL& url,
- content::NavigationController::ReloadType reload_type) OVERRIDE;
private:
- // Register this activity with its application.
- void RegisterActivity();
-
scoped_ptr<extensions::ShellAppWindow> app_window_;
views::WebView* web_view_;
@@ -70,11 +60,6 @@
// The image which will be used in overview mode.
gfx::ImageSkia overview_mode_image_;
- // If known the registry which holds all activities for the associated app.
- // This object is owned by |AppRegistry| and will be a valid pointer as long
- // as this object lives.
- AppActivityRegistry* app_activity_registry_;
-
DISALLOW_COPY_AND_ASSIGN(AppActivity);
};
« no previous file with comments | « trunk/src/athena/content/OWNERS ('k') | trunk/src/athena/content/app_activity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698