Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED

Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED

We're trying to kill off notifications, and this one's no
different.
Also, move the logic for notifying the location bar of
page actions being updated to ExtensionActionAPI.

BUG=406590
Committed: https://crrev.com/aeffd18ea04d1bdfc141383d547e1fe7494bb691
Cr-Commit-Position: refs/heads/master@{#291920}

[Devlin, 2014-08-22 21:42:09]

Fulfilling the promise made to Avi in
https://codereview.chromium.org/475813004/diff/20001/chrome/browser/extension...

Cheers! :)

[Avi (use Gerrit), 2014-08-22 21:57:45]

LGTM

Thank you!

[Finnur, 2014-08-25 13:47:56]

Couple of minor things...

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:423: if
(!extension_action)
If extension_action is non-null here, why call NotifyPageActionsChanged?

I guess this also applies to NotifyChange as well -- that's a generic
ExtensionAction function...

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/extension_action/extension_action_api.h:55:
virtual void OnExtensionActionAPIShuttingDown() {}
nit: Can you move these {} to the .cc file?

[Devlin, 2014-08-25 16:57:36]

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/extension_action/extension_action_api.cc
(right):

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/extension_action/extension_action_api.cc:423: if
(!extension_action)
On 2014/08/25 13:47:56, Finnur wrote:
> If extension_action is non-null here, why call NotifyPageActionsChanged?
> 
> I guess this also applies to NotifyChange as well -- that's a generic
> ExtensionAction function...

Whoops!  Rebasing mistake (too many patches touching the same files...).

Moved the NotifyPageActionsChanged to only be in NotifyChange, since this also
calls that method.  Of course, NotifyPageActionsChanged() will be called iff
it's actually a page action that changed.

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/extension_action/extension_action_api.h
(right):

https://codereview.chromium.org/496403003/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/extension_action/extension_action_api.h:55:
virtual void OnExtensionActionAPIShuttingDown() {}
On 2014/08/25 13:47:56, Finnur wrote:
> nit: Can you move these {} to the .cc file?

yep.

[Finnur, 2014-08-26 09:53:35]

LGTM

[Devlin, 2014-08-26 15:47:47]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-08-26 15:49:05]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/496403003/...

[commit-bot: I haz the power, 2014-08-26 17:04:26]

Committed patchset #6 (140001) as cf2e1a6e34a5f71921cbbd119d15548ceff6f837

[commit-bot: I haz the power, 2014-09-10 02:43:22]

Patchset 6 (id:??) landed as
https://crrev.com/aeffd18ea04d1bdfc141383d547e1fe7494bb691
Cr-Commit-Position: refs/heads/master@{#291920}