chrome/browser/extensions/lazy_background_page_apitest.cc - Issue 496403003: Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 496403003: Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master for CQ Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_test_notification_observer.cc ('k') | chrome/browser/extensions/location_bar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/lazy_background_page_apitest.cc

diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc

index 9a0f863abbfb004f31e6b6040b5d17dc5b2311ff..abf25cca28c2b9fc67307a1679fb42362b2efd3e 100644

--- a/chrome/browser/extensions/lazy_background_page_apitest.cc

+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc

@@ -7,7 +7,6 @@

#include "base/scoped_observer.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/bookmarks/bookmark_model_factory.h"

-#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/browser_action_test_util.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -24,7 +23,6 @@

#include "components/bookmarks/browser/bookmark_model.h"

#include "components/bookmarks/browser/bookmark_utils.h"

#include "components/bookmarks/test/bookmark_test_helpers.h"

-#include "content/public/browser/notification_service.h"

#include "content/public/browser/web_contents.h"

#include "content/public/test/browser_test_utils.h"

#include "extensions/browser/extension_host.h"

@@ -172,9 +170,6 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, BroadcastEvent) {

// Open a tab to a URL that will trigger the page action to show.

LazyBackgroundObserver page_complete;

- content::WindowedNotificationObserver page_action_changed(

- extensions::NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED,

- content::NotificationService::AllSources());

ui_test_utils::NavigateToURL(

browser(), embedded_test_server()->GetURL("/extensions/test_file.html"));

page_complete.Wait();

@@ -182,7 +177,7 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, BroadcastEvent) {

EXPECT_FALSE(IsBackgroundPageAlive(last_loaded_extension_id()));

// Page action is shown.

- page_action_changed.Wait();

+ WaitForPageActionVisibilityChangeTo(num_page_actions + 1);

EXPECT_EQ(num_page_actions + 1,

browser()->window()->GetLocationBar()->

GetLocationBarForTesting()->PageActionVisibleCount());