Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED

chrome/browser/extensions/api/extension_action/extension_action_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 26 matching lines @@
    public:
     // Called when there is a change to the given |extension_action|.
     // |web_contents| is the web contents that was affected, and
     // |browser_context| is the associated BrowserContext. (The latter is
     // included because ExtensionActionAPI is shared between normal and
     // incognito contexts, so |browser_context| may not equal
     // |browser_context_|.)
     virtual void OnExtensionActionUpdated(
         ExtensionAction* extension_action,
         content::WebContents* web_contents,
-        content::BrowserContext* browser_context) = 0;
+        content::BrowserContext* browser_context) {}
+
+    // Called when the page actions have been refreshed do to a possible change
+    // in count or visibility.
+    virtual void OnPageActionsUpdated(content::WebContents* web_contents) {}
 
     // Called when the ExtensionActionAPI is shutting down, giving observers a
     // chance to unregister themselves if there is not a definitive lifecycle.
     virtual void OnExtensionActionAPIShuttingDown() {}

[Finnur, 2014/08/25 13:47:56]

nit: Can you move these {} to the .cc file?

[Devlin, 2014/08/25 16:57:36]

yep.

 
    protected:
     virtual ~Observer() {}
   };
 
   explicit ExtensionActionAPI(content::BrowserContext* context);
   virtual ~ExtensionActionAPI();
 
   // Convenience method to get the instance for a profile.
   static ExtensionActionAPI* Get(content::BrowserContext* context);
@@ skipping 17 matching lines @@
                                     content::WebContents* web_contents);
 
   // BrowserContextKeyedAPI implementation.
   static BrowserContextKeyedAPIFactory<ExtensionActionAPI>*
       GetFactoryInstance();
 
   // Add or remove observers.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
+  // Notifies that there has been a change in the given |extension_action|.
   void NotifyChange(ExtensionAction* extension_action,
                     content::WebContents* web_contents,
                     content::BrowserContext* browser_context);
 
   // Clears the values for all ExtensionActions for the tab associated with the
-  // given |web_contents|.
+  // given |web_contents| (and signals that page actions changed).
   void ClearAllValuesForTab(content::WebContents* web_contents);
 
+  // Notifies that the current set of page actions for |web_contents| has
+  // changed, and signals the browser to update.
+  void NotifyPageActionsChanged(content::WebContents* web_contents);
+
  private:
   friend class BrowserContextKeyedAPIFactory<ExtensionActionAPI>;
 
   // The DispatchEvent methods forward events to the |profile|'s event router.
   static void DispatchEventToExtension(content::BrowserContext* context,
                                        const std::string& extension_id,
                                        const std::string& event_name,
                                        scoped_ptr<base::ListValue> event_args);
 
   // Called when either a browser or page action is executed. Figures out which
@@ skipping 361 matching lines @@
 class PageActionGetPopupFunction
     : public extensions::ExtensionActionGetPopupFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("pageAction.getPopup", PAGEACTION_GETPOPUP)
 
  protected:
   virtual ~PageActionGetPopupFunction() {}
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTION_API_H_