Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: chrome/browser/extensions/location_bar_controller.h

Issue 496403003: Remove NOTIFICATION_EXTENSION_PAGE_ACTIONS_UPDATED (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest master for CQ Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/location_bar_controller.h
diff --git a/chrome/browser/extensions/location_bar_controller.h b/chrome/browser/extensions/location_bar_controller.h
index 7faf2c17770d39be2ead5e323abb102addd011be..457800c936c7308638f7848428e4c4551a052dc6 100644
--- a/chrome/browser/extensions/location_bar_controller.h
+++ b/chrome/browser/extensions/location_bar_controller.h
@@ -44,8 +44,8 @@ class LocationBarController : public content::WebContentsObserver,
// A notification that the given |extension| has been unloaded, and any
// actions associated with it should be removed.
- // The location bar controller will update itself after this if needed, so
- // Providers should not call NotifyChange().
+ // The LocationBarController will handle notifying of page action changes,
+ // if any.
virtual void OnExtensionUnloaded(const Extension* extension) {}
};
@@ -55,9 +55,6 @@ class LocationBarController : public content::WebContentsObserver,
// Returns the actions which should be displayed in the location bar.
std::vector<ExtensionAction*> GetCurrentActions();
- // Notifies the window that the actions have changed.
- static void NotifyChange(content::WebContents* web_contents);
-
ActiveScriptController* active_script_controller() {
return active_script_controller_.get();
}
« no previous file with comments | « chrome/browser/extensions/lazy_background_page_apitest.cc ('k') | chrome/browser/extensions/location_bar_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698