Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 496273002: First tests for GCIdleTimeHandler. (Closed)

Created:
6 years, 4 months ago by ulan
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

First tests for GCIdleTimeHandler. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23316

Patch Set 1 #

Total comments: 1

Patch Set 2 : More tests, rebase #

Total comments: 1

Patch Set 3 : Use actual constants in tests #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -5 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A test/heap-unittests/heap-unittest.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
M test/heap-unittests/heap-unittest.cc View 1 2 2 chunks +140 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL. More tests will follow.
6 years, 4 months ago (2014-08-22 11:01:03 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/496273002/diff/1/test/heap-unittests/heap-unittest.h File test/heap-unittests/heap-unittest.h (right): https://codereview.chromium.org/496273002/diff/1/test/heap-unittests/heap-unittest.h#newcode21 test/heap-unittests/heap-unittest.h:21: GCIdleTimeHandler::HeapState initial_heap_state() { Can we make a method InitializeHeapState ...
6 years, 4 months ago (2014-08-22 11:06:30 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/496273002/diff/20001/test/heap-unittests/heap-unittest.cc File test/heap-unittests/heap-unittest.cc (right): https://codereview.chromium.org/496273002/diff/20001/test/heap-unittests/heap-unittest.cc#newcode144 test/heap-unittests/heap-unittest.cc:144: for (int i = 0; i < 100; i++) ...
6 years, 4 months ago (2014-08-22 12:54:59 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 4 months ago (2014-08-22 12:55:24 UTC) #4
ulan
6 years, 4 months ago (2014-08-22 13:26:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as 23316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698