Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 495093005: Remove implicit conversions from scoped_refptr to T* in net/url_request/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
mattm
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net/url_request/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/c2e01e8fa07a71047e376b686c8c66842be604e7 Cr-Commit-Position: refs/heads/master@{#292051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M net/url_request/url_request.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_filter_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_redirect_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + mattm@chromium.org
6 years, 3 months ago (2014-08-26 22:53:56 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 22:53:57 UTC) #2
mattm
lgtm
6 years, 3 months ago (2014-08-26 23:02:07 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-26 23:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/495093005/1
6 years, 3 months ago (2014-08-26 23:04:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 5b72ffc2e7efe23b928fe32a069cdc980be0abf6
6 years, 3 months ago (2014-08-27 00:24:53 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2e01e8fa07a71047e376b686c8c66842be604e7
Cr-Commit-Position: refs/heads/master@{#292051}

Powered by Google App Engine
This is Rietveld 408576698