Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: net/url_request/url_request_filter_unittest.cc

Issue 495093005: Remove implicit conversions from scoped_refptr to T* in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_filter_unittest.cc
diff --git a/net/url_request/url_request_filter_unittest.cc b/net/url_request/url_request_filter_unittest.cc
index 48a3cef796280c27b1b29fe5f7ba64fcc8ec5bad..dcc6a1b9bf71157c2148d57c7b04f44e93a60e75 100644
--- a/net/url_request/url_request_filter_unittest.cc
+++ b/net/url_request/url_request_filter_unittest.cc
@@ -71,7 +71,7 @@ TEST(URLRequestFilter, BasicMatching) {
{
scoped_refptr<URLRequestJob> found =
filter->MaybeInterceptRequest(&request_1, NULL);
- EXPECT_EQ(job_a, found);
+ EXPECT_EQ(job_a, found.get());
EXPECT_TRUE(job_a != NULL);
job_a = NULL;
}
@@ -93,7 +93,7 @@ TEST(URLRequestFilter, BasicMatching) {
{
scoped_refptr<URLRequestJob> found =
filter->MaybeInterceptRequest(&request_1, NULL);
- EXPECT_EQ(job_b, found);
+ EXPECT_EQ(job_b, found.get());
EXPECT_TRUE(job_b != NULL);
job_b = NULL;
}
@@ -117,7 +117,7 @@ TEST(URLRequestFilter, BasicMatching) {
{
scoped_refptr<URLRequestJob> found =
filter->MaybeInterceptRequest(&request_1, NULL);
- EXPECT_EQ(job_c, found);
+ EXPECT_EQ(job_c, found.get());
EXPECT_TRUE(job_c != NULL);
job_c = NULL;
}
@@ -132,7 +132,7 @@ TEST(URLRequestFilter, BasicMatching) {
{
scoped_refptr<URLRequestJob> found =
filter->MaybeInterceptRequest(&request_2, NULL);
- EXPECT_EQ(job_c, found);
+ EXPECT_EQ(job_c, found.get());
EXPECT_TRUE(job_c != NULL);
job_c = NULL;
}
« no previous file with comments | « net/url_request/url_request.cc ('k') | net/url_request/url_request_http_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698