Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 495093005: Remove implicit conversions from scoped_refptr to T* in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_filter_unittest.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index a870a2ca86b381a0444969620288137da2e5467d..d6b35dc59e5161552bf903ea967de966f3f45078 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -446,9 +446,9 @@ void URLRequestHttpJob::StartTransactionInternal() {
base::Bind(&URLRequestHttpJob::NotifyBeforeSendProxyHeadersCallback,
base::Unretained(this)));
- if (!throttling_entry_ ||
- !throttling_entry_->ShouldRejectRequest(
- *request_, network_delegate())) {
+ if (!throttling_entry_.get() ||
+ !throttling_entry_->ShouldRejectRequest(*request_,
+ network_delegate())) {
rv = transaction_->Start(
&request_info_, start_callback_, request_->net_log());
start_time_ = base::TimeTicks::Now();
@@ -1306,7 +1306,7 @@ void URLRequestHttpJob::DoneReadingRedirectResponse() {
} else {
// Otherwise, |override_response_headers_| must be non-NULL and contain
// bogus headers indicating a redirect.
- DCHECK(override_response_headers_);
+ DCHECK(override_response_headers_.get());
DCHECK(override_response_headers_->IsRedirect(NULL));
transaction_->StopCaching();
}
« no previous file with comments | « net/url_request/url_request_filter_unittest.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698