net/url_request/url_request_unittest.cc - Issue 495093005: Remove implicit conversions from scoped_refptr to T* in net/url_request/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_unittest.cc

Issue 495093005: Remove implicit conversions from scoped_refptr to T* in net/url_request/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_unittest.cc

diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc

index aea3ec4b7c9eff1583d1843adc810d3700eeddf8..7e22546891da70a95f2daeb57614a7c41bdf7289 100644

--- a/net/url_request/url_request_unittest.cc

+++ b/net/url_request/url_request_unittest.cc

@@ -7247,7 +7247,7 @@ class HTTPSOCSPTest : public HTTPSRequestTest {

scoped_refptr<X509Certificate> root_cert =

ImportCertFromFile(GetTestCertsDirectory(), "ocsp-test-root.pem");

- CHECK_NE(static_cast<X509Certificate*>(NULL), root_cert);

+ CHECK_NE(static_cast<X509Certificate*>(NULL), root_cert.get());

test_root_.reset(new ScopedTestRoot(root_cert.get()));

#if defined(USE_NSS) || defined(OS_IOS)

« no previous file with comments | « net/url_request/url_request_redirect_job.cc ('k') | no next file » | no next file with comments »