Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 494343003: Eliminate globalFlag usage from http security layout tests. (Closed)

Created:
6 years, 4 months ago by dcheng
Modified:
6 years, 4 months ago
Reviewers:
Tom Sepez
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Eliminate globalFlag usage from http security layout tests. Tests that polled globalFlag were using it as a way to figure out when another subframe had loaded. Instead of using globalFlag, those tests have been rewritten to use a combination of the window load event (which waits for all subframes to finish loading before firing), the iframe load event (which also waits for all subframes), and postMessage when a subframe can only start running its tests after the entire page is loaded. BUG=405846 R=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180782

Patch Set 1 #

Patch Set 2 : consistify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -633 lines) Patch
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html View 2 chunks +6 lines, -52 lines 0 comments Download
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html View 2 chunks +6 lines, -52 lines 0 comments Download
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-set-opener.html View 3 chunks +2 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-enumeration.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-custom-property-cached.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-override.html View 1 chunk +5 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-location-get.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-location-get-override.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-iframe.html View 2 chunks +2 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessee-opened-frame.html View 2 chunks +2 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-accessor-opened-frame.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/resources/foreign-domain-data-url-window-location.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open.html View 1 chunk +4 lines, -11 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html View 2 chunks +10 lines, -22 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url.html View 3 chunks +2 lines, -15 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open.html View 1 2 chunks +4 lines, -13 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe.html View 1 chunk +5 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change.html View 1 chunk +5 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open.html View 1 chunk +5 lines, -20 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level.html View 3 chunks +2 lines, -16 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html View 3 chunks +2 lines, -16 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/frameNavigation/resources/frame-with-link-to-navigate.html View 1 chunk +1 line, -14 lines 0 comments Download
M LayoutTests/http/tests/security/frameNavigation/resources/frame-with-plugin-to-navigate.html View 1 chunk +1 line, -14 lines 0 comments Download
M LayoutTests/http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html View 1 chunk +1 line, -13 lines 0 comments Download
M LayoutTests/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/host-compare-case-insensitive.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/host-compare-case-insensitive-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html View 2 chunks +1 line, -9 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-opened-frame.html View 2 chunks +1 line, -9 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html View 2 chunks +7 lines, -21 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html View 1 1 chunk +6 lines, -21 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html View 1 1 chunk +4 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html View 1 chunk +6 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html View 1 chunk +5 lines, -19 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-access-get-custom-property-cached-iframe.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-get-override-test.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-get-test.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-location-get-test.html View 1 chunk +1 line, -2 lines 0 comments Download
D LayoutTests/http/tests/security/resources/innocent-victim-with-notify.html View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/http/tests/security/resources/localhost-accesssor.html View 2 chunks +1 line, -13 lines 0 comments Download
M LayoutTests/http/tests/security/resources/open-window.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-javascript-with-spaces.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dcheng
6 years, 4 months ago (2014-08-22 15:32:59 UTC) #1
Tom Sepez
LGTM! Thanks for the cleanup.
6 years, 4 months ago (2014-08-22 16:32:31 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 4 months ago (2014-08-22 16:37:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/494343003/20001
6 years, 4 months ago (2014-08-22 16:38:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-22 16:43:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 16:45:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/8348)
6 years, 4 months ago (2014-08-22 16:45:51 UTC) #7
dcheng
6 years, 4 months ago (2014-08-22 16:50:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as 180782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698