LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html - Issue 494343003: Eliminate globalFlag usage from http security layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html

Issue 494343003: Eliminate globalFlag usage from http security layout tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: consistify Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt ('k') | LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html

diff --git a/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html b/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html

index 6c9e975aebe3c7053bb17a4191c40c1136a68f9c..ded14067c2ef1acaf2650c9598fc11dd63822422 100644

--- a/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html

+++ b/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open.html

@@ -15,8 +15,7 @@

+ "<head>"

+ "<scr" + "ipt>"

+ "function fireSentinel() {"

- + "if (window.testRunner)"

- + "testRunner.globalFlag = true;"

+ + "window.opener.postMessage('done', '*');"

+ "}"

+ "</scr" + "ipt>"

+ "</head>"

@@ -26,20 +25,8 @@

+ "</body>"

+ "</html>";

+ window.addEventListener('message', performTest);

openedWindow = window.open(url);

- if (window.testRunner) {

- setTimeout(waitForFlag, 1);

- function waitForFlag() {

- if (!testRunner.globalFlag) {

- setTimeout(waitForFlag, 1);

- return;

- }

- performTest();

- }

- } else {

- log("Click the button when all the subframes have finished loading.");

- }

}

function performTest() {

@@ -55,7 +42,6 @@

</head>

<p>Opener Frame</p>

- <button onclick="performTest()">Test</button>

</body>

</html>