LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html - Issue 494343003: Eliminate globalFlag usage from http security layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html

Issue 494343003: Eliminate globalFlag usage from http security layout tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: consistify Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html ('k') | LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html

diff --git a/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html b/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html

index e7d6756fe0f84f6888c46695c7887e2354692510..5d18a05596b24ae47252ecb29dcbdb1007a92147 100644

--- a/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html

+++ b/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html

@@ -15,8 +15,7 @@

+ "<scr" + "ipt>"

+ "window.onload = function()"

+ "{"

- + "if (window.testRunner)"

- + "testRunner.globalFlag = true;"

+ + 'window.top.postMessage(\\\\\\"run test\\\\\\", \\\\\\"*\\\\\\");'

+ "}"

+ "</scr" + "ipt>"

+ "</head>"

@@ -36,25 +35,12 @@

var iframe = document.getElementById("aFrame");

iframe.src = url;

- if (window.testRunner) {

- setTimeout(pollForTest, 1);

- } else {

- log("To run the test, click the button below when the opened window finishes loading.");

- var button = document.createElement("button");

- button.appendChild(document.createTextNode("Run Test"));

- button.onclick = runTest;

- document.body.appendChild(button);

- }

- pollForTest = function()

- {

- if (!testRunner.globalFlag) {

- setTimeout(pollForTest, 1);

- return;

- }

- runTest();

- testRunner.notifyDone();

+ window.addEventListener('message', function ()

+ {

+ runTest();

+ if (window.testRunner)

+ testRunner.notifyDone();

+ });

}

runTest = function()