LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html - Issue 494343003: Eliminate globalFlag usage from http security layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html

Issue 494343003: Eliminate globalFlag usage from http security layout tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: consistify Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html ('k') | LayoutTests/http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html

diff --git a/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html b/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html

index a6139643391e04023b895a18d71aae2ae1ebce32..6018c7d30dcd57457a22e0a9144d096f9fbf2c81 100644

--- a/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html

+++ b/LayoutTests/http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html

@@ -12,29 +12,14 @@

testRunner.setCanOpenWindows();

}

- var url = "javascript:\"<html><head><scr" + "ipt>window.onload = function() { if (window.testRunner) testRunner.globalFlag = true; }</scr" + "ipt></head><body>Opened FrameFAIL</body></html>\"";

+ var url = "javascript:\"<html><head><scr" + "ipt>window.onload = function() { window.opener.postMessage('run test', '*'); }</scr" + "ipt></head><body>Opened FrameFAIL</body></html>\"";

openedWindow = window.open(url);

- if (window.testRunner) {

- setTimeout(pollForTest, 1);

- } else {

- log("To run the test, click the button below when the opened window finishes loading.");

- var button = document.createElement("button");

- button.appendChild(document.createTextNode("Run Test"));

- button.onclick = runTest;

- document.body.appendChild(button);

- }

- pollForTest = function()

- {

- if (!testRunner.globalFlag) {

- setTimeout(pollForTest, 1);

- return;

- }

- runTest();

- closeWindowAndNotifyDone(openedWindow);

+ window.addEventListener('message', function ()

+ {

+ runTest();

+ closeWindowAndNotifyDone(openedWindow);

+ });

}

runTest = function()