Make app APIs implicit within _api_features.json not _permission_features.json.

Make app APIs implicit within _api_features.json not _permission_features.json.
Remove the automatic granting of features to component extensions (they can
still request them).

BUG=310707
R=yoz@chromium.org
TBR=achuith@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231504

[not at google - send to devlin, 2013-10-28 22:42:49]

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
File chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json
(left):

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json:5:
"permissions": [ "app.runtime" ],
The test is that installing this app results in no warnings, which now that this
isn't a permission, isn't the case.

This change is still backwards compatible - these are install warnings, not
errors.

[Yoyo Zhou, 2013-10-28 22:54:27]

LGTM

[rpaquay, 2013-10-28 22:54:45]

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
File chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json
(left):

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json:5:
"permissions": [ "app.runtime" ],
On 2013/10/28 22:42:50, kalman wrote:
> The test is that installing this app results in no warnings, which now that
this
> isn't a permission, isn't the case.
> 
> This change is still backwards compatible - these are install warnings, not
> errors.

Shouldn't we also remove this permission from 
chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json
chrome/test/ext_auto/auto_provider/manifest.json
?

[not at google - send to devlin, 2013-10-28 22:57:15]

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
File chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json
(left):

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json:5:
"permissions": [ "app.runtime" ],
On 2013/10/28 22:54:45, rpaquay wrote:
> On 2013/10/28 22:42:50, kalman wrote:
> > The test is that installing this app results in no warnings, which now that
> this
> > isn't a permission, isn't the case.
> > 
> > This change is still backwards compatible - these are install warnings, not
> > errors.
> 
> Shouldn't we also remove this permission from 
> chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json
> chrome/test/ext_auto/auto_provider/manifest.json
> ?

Yes. Thanks.

[rpaquay, 2013-10-28 23:01:30]

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
File chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json
(left):

https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json:5:
"permissions": [ "app.runtime" ],
On 2013/10/28 22:57:15, kalman wrote:
> On 2013/10/28 22:54:45, rpaquay wrote:
> > On 2013/10/28 22:42:50, kalman wrote:
> > > The test is that installing this app results in no warnings, which now
that
> > this
> > > isn't a permission, isn't the case.
> > > 
> > > This change is still backwards compatible - these are install warnings,
not
> > > errors.
> > 
> > Shouldn't we also remove this permission from 
> > chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json
> > chrome/test/ext_auto/auto_provider/manifest.json
> > ?
> 
> Yes. Thanks.

Do another quick search, and found "app.window" here:

chrome/test/ext_auto/auto_provider/manifest.json
chrome/test/data/extensions/platform_apps/apps_only/manifest.json

I assume they should be remove too.

[not at google - send to devlin, 2013-10-28 23:02:58]

On 2013/10/28 23:01:30, rpaquay wrote:
>
https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
> File chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json
> (left):
> 
>
https://codereview.chromium.org/49333004/diff/190001/chrome/test/data/extensi...
> chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json:5:
> "permissions": [ "app.runtime" ],
> On 2013/10/28 22:57:15, kalman wrote:
> > On 2013/10/28 22:54:45, rpaquay wrote:
> > > On 2013/10/28 22:42:50, kalman wrote:
> > > > The test is that installing this app results in no warnings, which now
> that
> > > this
> > > > isn't a permission, isn't the case.
> > > > 
> > > > This change is still backwards compatible - these are install warnings,
> not
> > > > errors.
> > > 
> > > Shouldn't we also remove this permission from 
> > > chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json
> > > chrome/test/ext_auto/auto_provider/manifest.json
> > > ?
> > 
> > Yes. Thanks.
> 
> Do another quick search, and found "app.window" here:
> 
> chrome/test/ext_auto/auto_provider/manifest.json
> chrome/test/data/extensions/platform_apps/apps_only/manifest.json
> 
> I assume they should be remove too.

thanks. they're not causing tests to fail so I didn't notice.

[commit-bot: I haz the power, 2013-10-28 23:09:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/49333004/300001

[rpaquay, 2013-10-28 23:11:58]

On 2013/10/28 23:02:58, kalman wrote:
> > Do another quick search, and found "app.window" here:
> 
> thanks. they're not causing tests to fail so I didn't notice.

(oops, sorry, typo, I meant "I did another quick search and found...").

[commit-bot: I haz the power, 2013-10-29 00:02:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-10-29 00:22:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/49333004/300001

[commit-bot: I haz the power, 2013-10-29 01:00:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_rel_device.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-29 01:26:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/49333004/300001

[commit-bot: I haz the power, 2013-10-29 03:23:27]

Change committed as 231504

[not at google - send to devlin, 2013-10-30 23:10:00]

ping @yoz. I've fixed the problem with the breakage of component extensions (or
at least, chromevox is working) by disabling the whitelisting of features for
component extensions. this shouldn't matter since component extensions should
still be requesting the correct permissions etc.

[Yoyo Zhou, 2013-10-30 23:25:19]

On 2013/10/30 23:10:00, kalman wrote:
> ping @yoz. I've fixed the problem with the breakage of component extensions
(or
> at least, chromevox is working) by disabling the whitelisting of features for
> component extensions. this shouldn't matter since component extensions should
> still be requesting the correct permissions etc.

Is there something I should review?

You say "should" but I think it's possible that some component extension fails
to request its permissions.

[Yoyo Zhou, 2013-10-30 23:27:25]

LGTM

[commit-bot: I haz the power, 2013-10-31 00:02:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/49333004/590001

[commit-bot: I haz the power, 2013-10-31 03:06:42]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...