chrome/common/extensions/features/simple_feature.cc - Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/simple_feature.cc

Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: delete component extension granting Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/_permission_features.json ('k') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/simple_feature.cc

diff --git a/chrome/common/extensions/features/simple_feature.cc b/chrome/common/extensions/features/simple_feature.cc

index 694b90d5129304dad30b406af6968546a495b746..7de159d94bcbc29dde52b2c787dd5abe8aecaf1a 100644

--- a/chrome/common/extensions/features/simple_feature.cc

+++ b/chrome/common/extensions/features/simple_feature.cc

@@ -313,10 +313,6 @@ Feature::Availability SimpleFeature::IsAvailableToManifest(

Location location,

int manifest_version,

Platform platform) const {

- // Component extensions can access any feature.

- if (location == COMPONENT_LOCATION)

- return CreateAvailability(IS_AVAILABLE, type);

if (!whitelist_.empty()) {

if (!IsIdInWhitelist(extension_id)) {

// TODO(aa): This is gross. There should be a better way to test the