Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: delete component extension granting Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 TEST(PermissionsTest, PermissionMessages) { 633 TEST(PermissionsTest, PermissionMessages) {
634 // Ensure that all permissions that needs to show install UI actually have 634 // Ensure that all permissions that needs to show install UI actually have
635 // strings associated with them. 635 // strings associated with them.
636 APIPermissionSet skip; 636 APIPermissionSet skip;
637 637
638 // These are considered "nuisance" or "trivial" permissions that don't need 638 // These are considered "nuisance" or "trivial" permissions that don't need
639 // a prompt. 639 // a prompt.
640 skip.insert(APIPermission::kActiveTab); 640 skip.insert(APIPermission::kActiveTab);
641 skip.insert(APIPermission::kAdView); 641 skip.insert(APIPermission::kAdView);
642 skip.insert(APIPermission::kAlarms); 642 skip.insert(APIPermission::kAlarms);
643 skip.insert(APIPermission::kAppCurrentWindowInternal);
644 skip.insert(APIPermission::kAppRuntime);
645 skip.insert(APIPermission::kAppWindow);
646 skip.insert(APIPermission::kAudio); 643 skip.insert(APIPermission::kAudio);
647 skip.insert(APIPermission::kBrowsingData); 644 skip.insert(APIPermission::kBrowsingData);
648 skip.insert(APIPermission::kContextMenus); 645 skip.insert(APIPermission::kContextMenus);
649 skip.insert(APIPermission::kDiagnostics); 646 skip.insert(APIPermission::kDiagnostics);
650 skip.insert(APIPermission::kDns); 647 skip.insert(APIPermission::kDns);
651 skip.insert(APIPermission::kDownloadsShelf); 648 skip.insert(APIPermission::kDownloadsShelf);
652 skip.insert(APIPermission::kFontSettings); 649 skip.insert(APIPermission::kFontSettings);
653 skip.insert(APIPermission::kFullscreen); 650 skip.insert(APIPermission::kFullscreen);
654 skip.insert(APIPermission::kIdle); 651 skip.insert(APIPermission::kIdle);
655 skip.insert(APIPermission::kIdltest); 652 skip.insert(APIPermission::kIdltest);
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
1444 scoped_refptr<const PermissionSet> permissions_dwr( 1441 scoped_refptr<const PermissionSet> permissions_dwr(
1445 extension_dwr->GetActivePermissions()); 1442 extension_dwr->GetActivePermissions());
1446 1443
1447 EXPECT_FALSE(PermissionMessageProvider::Get()-> 1444 EXPECT_FALSE(PermissionMessageProvider::Get()->
1448 IsPrivilegeIncrease(permissions.get(), 1445 IsPrivilegeIncrease(permissions.get(),
1449 permissions_dwr.get(), 1446 permissions_dwr.get(),
1450 extension->GetType())); 1447 extension->GetType()));
1451 } 1448 }
1452 1449
1453 } // namespace extensions 1450 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698