chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json - Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json.

Side by Side Diff: chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json

Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix messaging test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 {	1 {

2 "key": "AAAAB3NzaC1yc2EAAAADAQABAAABAQDbh1pj7Q+vZzotbfPfe1Q4AIeJc3gU1xhTSMtjB0 UZH+G3ckScJYTnFCTkFAn/mEOtn7e+SZ9rhDf4k6X7Qf6BzK3PLNn3+2Hb/F0NC57hiWI2UyhXY2dl2r y6VENkuyo1QpEMGH5FB5tC2rcuivG8ipBbUWLoQLMbegUdOLXoNK4tGvKwlGa1B0QPAMIkEw3ZlerckC 8e+tWC38WvHxy1EM5VeK8k4GcrDEltoVByprTe/8VTzvEsFFYljpIzbSTi6mKOhY2sdl0EfCpXT4dSCe Se81O8liMU1yYKBQCbzguASV7yzZMX08tb96MOpx0NYbYXt03Zyj3xlbep5n4l",	2 "key": "AAAAB3NzaC1yc2EAAAADAQABAAABAQDbh1pj7Q+vZzotbfPfe1Q4AIeJc3gU1xhTSMtjB0 UZH+G3ckScJYTnFCTkFAn/mEOtn7e+SZ9rhDf4k6X7Qf6BzK3PLNn3+2Hb/F0NC57hiWI2UyhXY2dl2r y6VENkuyo1QpEMGH5FB5tC2rcuivG8ipBbUWLoQLMbegUdOLXoNK4tGvKwlGa1B0QPAMIkEw3ZlerckC 8e+tWC38WvHxy1EM5VeK8k4GcrDEltoVByprTe/8VTzvEsFFYljpIzbSTi6mKOhY2sdl0EfCpXT4dSCe Se81O8liMU1yYKBQCbzguASV7yzZMX08tb96MOpx0NYbYXt03Zyj3xlbep5n4l",

3 "name": "Messaging Test App 2",	3 "name": "Messaging Test App 2",

4 "version": "0.5",	4 "version": "0.5",

5 "permissions": [ "app.runtime" ],
not at google - send to devlin 2013/10/28 22:42:50 The test is that installing this app results in no The test is that installing this app results in no warnings, which now that this isn't a permission, isn't the case. This change is still backwards compatible - these are install warnings, not errors. rpaquay 2013/10/28 22:54:45 Shouldn't we also remove this permission from chr Show quoted text On 2013/10/28 22:42:50, kalman wrote: > The test is that installing this app results in no warnings, which now that this > isn't a permission, isn't the case. > > This change is still backwards compatible - these are install warnings, not > errors. Shouldn't we also remove this permission from chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json chrome/test/ext_auto/auto_provider/manifest.json ? not at google - send to devlin 2013/10/28 22:57:15 Yes. Thanks. Show quoted text On 2013/10/28 22:54:45, rpaquay wrote: > On 2013/10/28 22:42:50, kalman wrote: > > The test is that installing this app results in no warnings, which now that > this > > isn't a permission, isn't the case. > > > > This change is still backwards compatible - these are install warnings, not > > errors. > > Shouldn't we also remove this permission from > chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json > chrome/test/ext_auto/auto_provider/manifest.json > ? Yes. Thanks. rpaquay 2013/10/28 23:01:31 Do another quick search, and found "app.window" he Show quoted text On 2013/10/28 22:57:15, kalman wrote: > On 2013/10/28 22:54:45, rpaquay wrote: > > On 2013/10/28 22:42:50, kalman wrote: > > > The test is that installing this app results in no warnings, which now that > > this > > > isn't a permission, isn't the case. > > > > > > This change is still backwards compatible - these are install warnings, not > > > errors. > > > > Shouldn't we also remove this permission from > > chrome/test/data/extensions/platform_apps/messaging/app1/manifest.json > > chrome/test/ext_auto/auto_provider/manifest.json > > ? > > Yes. Thanks. Do another quick search, and found "app.window" here: chrome/test/ext_auto/auto_provider/manifest.json chrome/test/data/extensions/platform_apps/apps_only/manifest.json I assume they should be remove too.
6 "app": {	5 "app": {

7 "background": {	6 "background": {

8 "scripts": ["background.js"]	7 "scripts": ["background.js"]

9 }	8 }

10 }	9 }

11 }	10 }

OLD	NEW

« no previous file with comments | « chrome/common/extensions/permissions/permissions_data.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »