Chromium Code Reviews| Index: Source/modules/geolocation/GeolocationClient.h |
| diff --git a/Source/modules/geolocation/GeolocationClient.h b/Source/modules/geolocation/GeolocationClient.h |
| index 9b51f367e7034bb46b2880ac05ae52b5d55effcf..609b75e691cd9c380bd95e26c057017cf3a3685e 100644 |
| --- a/Source/modules/geolocation/GeolocationClient.h |
| +++ b/Source/modules/geolocation/GeolocationClient.h |
| @@ -26,6 +26,8 @@ |
| #ifndef GeolocationClient_h |
| #define GeolocationClient_h |
| +#include "platform/heap/Handle.h" |
| + |
| namespace blink { |
| class Geolocation; |
| @@ -33,9 +35,9 @@ class GeolocationController; |
| class GeolocationPosition; |
| class LocalFrame; |
| -class GeolocationClient { |
| +class GeolocationClient : public NoBaseWillBeGarbageCollectedFinalized<GeolocationClient> { |
|
sof
2014/08/21 09:43:41
It is arguably moot to insist on *Finalized here (
|
| public: |
| - virtual void geolocationDestroyed() = 0; |
|
sof
2014/08/21 09:43:42
If this CL goes ahead, geolocationDestroyed() can
|
| + virtual ~GeolocationClient() { } |
| virtual void startUpdating() = 0; |
| virtual void stopUpdating() = 0; |
| @@ -48,8 +50,7 @@ public: |
| virtual void controllerForTestAdded(GeolocationController*) { } |
| virtual void controllerForTestRemoved(GeolocationController*) { } |
| -protected: |
| - virtual ~GeolocationClient() { } |
| + virtual void trace(Visitor*) { } |
| }; |
| void provideGeolocationTo(LocalFrame&, GeolocationClient*); |