Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1881)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/modules/geolocation/GeolocationController.h

Issue 490143002: Move GeolocationClient to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/modules/geolocation/GeolocationClient.h ('K') | « Source/modules/geolocation/GeolocationClient.h ('k') | Source/modules/geolocation/GeolocationController.cpp » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/geolocation/GeolocationController.h
diff --git a/Source/modules/geolocation/GeolocationController.h b/Source/modules/geolocation/GeolocationController.h
index e50da4645eb490c40df6af4e5305a5fac1e7e878..314819dc63d340412a9ab534a8426a126497c337 100644
--- a/Source/modules/geolocation/GeolocationController.h
+++ b/Source/modules/geolocation/GeolocationController.h
@@ -71,7 +71,6 @@ public:
// Inherited from Supplement.
virtual void trace(Visitor*) OVERRIDE;
- virtual void willBeDestroyed() OVERRIDE;
virtual void persistentHostHasBeenDestroyed() OVERRIDE;
private:
@@ -80,9 +79,7 @@ private:
void startUpdatingIfNeeded();
void stopUpdatingIfNeeded();
- void detach();
-
- GeolocationClient* m_client;
+ RawPtrWillBeMember<GeolocationClient> m_client;
bool m_hasClientForTest;
PersistentWillBeMember<GeolocationPosition> m_lastPosition;
« Source/modules/geolocation/GeolocationClient.h ('K') | « Source/modules/geolocation/GeolocationClient.h ('k') | Source/modules/geolocation/GeolocationController.cpp » ('j') | Source/web/WebLocalFrameImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698